From: Sven Schnelle <svens@stackframe.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: netdev@vger.kernel.org, linux-parisc@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Yang Wei <yang.wei9@zte.com.cn>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Aditya Pakki <pakki001@umn.edu>,
Kangjie Lu <kjlu@umn.edu>, Navid Emamdoost <emamd001@umn.edu>,
Stephen McCamant <smccaman@umn.edu>
Subject: Re: net: tulip: de2104x: Checking a kmemdup() call in de21041_get_srom_info()
Date: Sat, 12 Oct 2019 17:20:55 +0000 [thread overview]
Message-ID: <20191012172055.GA22569@t470p.stackframe.org> (raw)
In-Reply-To: <eb1f904a-a2e4-fe9b-c50e-b8087d7e57c4@web.de>
On Sat, Oct 12, 2019 at 07:03:09PM +0200, Markus Elfring wrote:
> Hello,
>
> I tried another script for the semantic patch language out.
> This source code analysis approach points out that the implementation
> of the function “de21041_get_srom_info” contains still an unchecked call
> of the function “kmemdup”.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/dec/tulip/de2104x.c?id\x1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n1940
> https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/net/ethernet/dec/tulip/de2104x.c#L1940
>
> How do you think about to improve it?
If i have not missed a place, the only user is de_get_eeprom(), which checks
whether de->ee_data is valid. So i think although not obvious, there's no
problem here.
Regards
Sven
prev parent reply other threads:[~2019-10-12 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 17:03 net: tulip: de2104x: Checking a kmemdup() call in de21041_get_srom_info() Markus Elfring
2019-10-12 17:20 ` Sven Schnelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191012172055.GA22569@t470p.stackframe.org \
--to=svens@stackframe.org \
--cc=Markus.Elfring@web.de \
--cc=davem@davemloft.net \
--cc=emamd001@umn.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=smccaman@umn.edu \
--cc=yang.wei9@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).