* net: tulip: de2104x: Checking a kmemdup() call in de21041_get_srom_info()
@ 2019-10-12 17:03 Markus Elfring
2019-10-12 17:20 ` Sven Schnelle
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2019-10-12 17:03 UTC (permalink / raw)
To: netdev, linux-parisc, David S. Miller, Yang Wei
Cc: LKML, kernel-janitors, Aditya Pakki, Kangjie Lu, Navid Emamdoost,
Stephen McCamant
Hello,
I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “de21041_get_srom_info” contains still an unchecked call
of the function “kmemdup”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/dec/tulip/de2104x.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n1940
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/net/ethernet/dec/tulip/de2104x.c#L1940
How do you think about to improve it?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: net: tulip: de2104x: Checking a kmemdup() call in de21041_get_srom_info()
2019-10-12 17:03 net: tulip: de2104x: Checking a kmemdup() call in de21041_get_srom_info() Markus Elfring
@ 2019-10-12 17:20 ` Sven Schnelle
0 siblings, 0 replies; 2+ messages in thread
From: Sven Schnelle @ 2019-10-12 17:20 UTC (permalink / raw)
To: Markus Elfring
Cc: netdev, linux-parisc, David S. Miller, Yang Wei, LKML,
kernel-janitors, Aditya Pakki, Kangjie Lu, Navid Emamdoost,
Stephen McCamant
On Sat, Oct 12, 2019 at 07:03:09PM +0200, Markus Elfring wrote:
> Hello,
>
> I tried another script for the semantic patch language out.
> This source code analysis approach points out that the implementation
> of the function “de21041_get_srom_info” contains still an unchecked call
> of the function “kmemdup”.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/dec/tulip/de2104x.c?id\x1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n1940
> https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/net/ethernet/dec/tulip/de2104x.c#L1940
>
> How do you think about to improve it?
If i have not missed a place, the only user is de_get_eeprom(), which checks
whether de->ee_data is valid. So i think although not obvious, there's no
problem here.
Regards
Sven
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-12 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-12 17:03 net: tulip: de2104x: Checking a kmemdup() call in de21041_get_srom_info() Markus Elfring
2019-10-12 17:20 ` Sven Schnelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).