From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Date: Fri, 08 May 2020 13:02:21 +0000 Subject: Re: [PATCH] iio: sca3000: Remove an erroneous 'get_device()' Message-Id: <20200508140221.0000018d@Huawei.com> List-Id: References: <20200506035206.192173-1-christophe.jaillet@wanadoo.fr> <0a8cd600-2b21-2076-1355-8c97d7ceb709@wanadoo.fr> In-Reply-To: <0a8cd600-2b21-2076-1355-8c97d7ceb709@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Marion & Christophe JAILLET Cc: Andy Shevchenko , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , "Enrico Weigelt, metux IT consult" , Greg Kroah-Hartman , Dan Carpenter , Thomas Gleixner , linux-iio , Linux Kernel Mailing List , kernel-janitors@vger.kernel.org On Wed, 6 May 2020 19:31:38 +0200 Marion & Christophe JAILLET wrote: > Le 06/05/2020 =E0 12:38, Andy Shevchenko a =E9crit=A0: > > On Wed, May 6, 2020 at 6:55 AM Christophe JAILLET > > wrote: =20 > >> This looks really unusual to have a 'get_device()' hidden in a 'dev_er= r()' > >> call. > >> Remove it. > >> > >> While at it add a missing \n at the end of the message. > >> =20 > > It should have Fixes tag because it is a quite an issue (get_device() > > breaks reference counting with all problems we may expect). =20 >=20 > Agreed and I usually do, but here, I've lost track when this driver has=20 > gone out of staging. >=20 > Based on: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/d= rivers/iio/accel/sca3000.c > The issue was already there on 2016/10/23, but when I try to go one step = > further: >=20 > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/= drivers/staging/iio/accel/sca3000.c?id,cf61442ff142d2dde7c47471c2798a4d78b0= ad > ^^^^ =A0=A0=A0=A0=A0=A0=A0 ^^^^^^^ > works but if I try to see the log for that: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/d= rivers/staging/iio/accel/sca3000.c > ^^^=A0=A0=A0=A0=A0=A0=A0=A0 ^^^^^^^ > is empty. >=20 > Most of the time, when I do it like that it works just fine, but not on=20 > this file. Oddity of the web interface. Edit the url to get a log form a commit https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/dri= vers/staging/iio/accel/sca3000.c?id,cf61442ff142d2dde7c47471c2798a4d78b0ad ^^^ Then for more fun you have to deal with another rename https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/= drivers/staging/iio/accel/?id=CEd5c03d360aeebaac6faa7dd8d6d0a77733ab16 Next bit of log... https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/dri= vers/staging/iio/accel/sca3000_ring.c?id=CEd5c03d360aeebaac6faa7dd8d6d0a777= 33ab16=20 It goes all the way.. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/= drivers/staging/iio/accel/sca3000_core.c?idW4fb258d63658e4564c32c1940068a3b= ad666a0 Fixes: 574fb258d636 ("Staging: IIO: VTI sca3000 series accelerometer driver= (spi)") Which was in the initial IIO patch set nearly 11 years ago in the merge win= dow for 2.6.32. What can I say - I was young and just as capable of writing dumb bugs as I = am today :) I'll get this queued up when I'm on the right computer... Thanks, Jonathan >=20 > Any other way to navigate in history of moved file would be appreciated. >=20 > CJ >=20 > > =20 > >> Signed-off-by: Christophe JAILLET > >> --- > >> This patch is purely speculative. > >> I've looked a bit arround and see no point for this get_device() but o= ther > >> eyes are welcomed :) > >> --- > >> drivers/iio/accel/sca3000.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c > >> index 66d768d971e1..6e429072e44a 100644 > >> --- a/drivers/iio/accel/sca3000.c > >> +++ b/drivers/iio/accel/sca3000.c > >> @@ -980,7 +980,7 @@ static int sca3000_read_data(struct sca3000_state = *st, > >> st->tx[0] =3D SCA3000_READ_REG(reg_address_high); > >> ret =3D spi_sync_transfer(st->us, xfer, ARRAY_SIZE(xfer)); > >> if (ret) { > >> - dev_err(get_device(&st->us->dev), "problem reading reg= ister"); > >> + dev_err(&st->us->dev, "problem reading register\n"); > >> return ret; > >> } > >> > >> -- > >> 2.25.1 > >> =20 > > =20