* [PATCH -next] bus: mhi: core: Fix some error return code
@ 2020-05-09 7:56 Wei Yongjun
2020-05-11 10:43 ` Manivannan Sadhasivam
0 siblings, 1 reply; 5+ messages in thread
From: Wei Yongjun @ 2020-05-09 7:56 UTC (permalink / raw)
To: Manivannan Sadhasivam, Hemant Kumar, Jeffrey Hugo,
Greg Kroah-Hartman, Sujeev Dias, Siddartha Mohanadoss
Cc: Wei Yongjun, linux-arm-msm, kernel-janitors, Hulk Robot
Fix to return negative error code from the error handling case
instead of 0 in mhi_init_dev_ctxt() and mhi_driver_probe().
Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/bus/mhi/core/init.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index eb2ab058a01d..1f8c82603179 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -291,6 +291,7 @@ int mhi_init_dev_ctxt(struct mhi_controller *mhi_cntrl)
}
/* Setup cmd context */
+ ret = -ENOMEM;
mhi_ctxt->cmd_ctxt = mhi_alloc_coherent(mhi_cntrl,
sizeof(*mhi_ctxt->cmd_ctxt) *
NR_OF_CMD_RINGS,
@@ -1100,6 +1101,7 @@ static int mhi_driver_probe(struct device *dev)
}
}
+ ret = -EINVAL;
if (dl_chan) {
/*
* If channel supports LPM notifications then status_cb should
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH -next] bus: mhi: core: Fix some error return code
2020-05-09 7:56 [PATCH -next] bus: mhi: core: Fix some error return code Wei Yongjun
@ 2020-05-11 10:43 ` Manivannan Sadhasivam
2020-05-11 14:26 ` AW: " Walter Harms
0 siblings, 1 reply; 5+ messages in thread
From: Manivannan Sadhasivam @ 2020-05-11 10:43 UTC (permalink / raw)
To: Wei Yongjun
Cc: Hemant Kumar, Jeffrey Hugo, Greg Kroah-Hartman, Sujeev Dias,
Siddartha Mohanadoss, linux-arm-msm, kernel-janitors, Hulk Robot
On 0509, Wei Yongjun wrote:
> Fix to return negative error code from the error handling case
> instead of 0 in mhi_init_dev_ctxt() and mhi_driver_probe().
>
> Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/bus/mhi/core/init.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index eb2ab058a01d..1f8c82603179 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -291,6 +291,7 @@ int mhi_init_dev_ctxt(struct mhi_controller *mhi_cntrl)
> }
>
> /* Setup cmd context */
> + ret = -ENOMEM;
> mhi_ctxt->cmd_ctxt = mhi_alloc_coherent(mhi_cntrl,
> sizeof(*mhi_ctxt->cmd_ctxt) *
> NR_OF_CMD_RINGS,
> @@ -1100,6 +1101,7 @@ static int mhi_driver_probe(struct device *dev)
> }
> }
>
> + ret = -EINVAL;
> if (dl_chan) {
> /*
> * If channel supports LPM notifications then status_cb should
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* AW: [PATCH -next] bus: mhi: core: Fix some error return code
2020-05-11 10:43 ` Manivannan Sadhasivam
@ 2020-05-11 14:26 ` Walter Harms
2020-05-11 14:56 ` Manivannan Sadhasivam
2020-05-11 18:43 ` Dan Carpenter
0 siblings, 2 replies; 5+ messages in thread
From: Walter Harms @ 2020-05-11 14:26 UTC (permalink / raw)
To: Manivannan Sadhasivam, Wei Yongjun
Cc: Hemant Kumar, Jeffrey Hugo, Greg Kroah-Hartman, Sujeev Dias,
Siddartha Mohanadoss, linux-arm-msm@vger.kernel.org,
kernel-janitors@vger.kernel.org, Hulk Robot
Hello guys,
some nitpicking ...
the prefered kernalstyle is:
if (condition)
set error_code
do something
from what i can see it is
set error_code
if (condition)
jm2c
re,
wh
________________________________________
Von: kernel-janitors-owner@vger.kernel.org <kernel-janitors-owner@vger.kernel.org> im Auftrag von Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Gesendet: Montag, 11. Mai 2020 12:31:24
An: Wei Yongjun
Cc: Hemant Kumar; Jeffrey Hugo; Greg Kroah-Hartman; Sujeev Dias; Siddartha Mohanadoss; linux-arm-msm@vger.kernel.org; kernel-janitors@vger.kernel.org; Hulk Robot
Betreff: Re: [PATCH -next] bus: mhi: core: Fix some error return code
On 0509, Wei Yongjun wrote:
> Fix to return negative error code from the error handling case
> instead of 0 in mhi_init_dev_ctxt() and mhi_driver_probe().
>
> Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/bus/mhi/core/init.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index eb2ab058a01d..1f8c82603179 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -291,6 +291,7 @@ int mhi_init_dev_ctxt(struct mhi_controller *mhi_cntrl)
> }
>
> /* Setup cmd context */
> + ret = -ENOMEM;
> mhi_ctxt->cmd_ctxt = mhi_alloc_coherent(mhi_cntrl,
> sizeof(*mhi_ctxt->cmd_ctxt) *
> NR_OF_CMD_RINGS,
> @@ -1100,6 +1101,7 @@ static int mhi_driver_probe(struct device *dev)
> }
> }
>
> + ret = -EINVAL;
> if (dl_chan) {
> /*
> * If channel supports LPM notifications then status_cb should
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] bus: mhi: core: Fix some error return code
2020-05-11 14:26 ` AW: " Walter Harms
@ 2020-05-11 14:56 ` Manivannan Sadhasivam
2020-05-11 18:43 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2020-05-11 14:56 UTC (permalink / raw)
To: Walter Harms
Cc: Wei Yongjun, Hemant Kumar, Jeffrey Hugo, Greg Kroah-Hartman,
Sujeev Dias, Siddartha Mohanadoss, linux-arm-msm@vger.kernel.org,
kernel-janitors@vger.kernel.org, Hulk Robot
On Mon, May 11, 2020 at 02:26:10PM +0000, Walter Harms wrote:
> Hello guys,
> some nitpicking ...
> the prefered kernalstyle is:
>
> if (condition)
> set error_code
> do something
>
> from what i can see it is
>
> set error_code
> if (condition)
>
There are multiple error paths which share the same error code. So I don't
see any benefit of setting same error code in all the paths.
The recommended style makes perfect sense for an error path which has a unique
error code but not for the above.
Thanks,
Mani
> jm2c
> re,
> wh
>
> ________________________________________
> Von: kernel-janitors-owner@vger.kernel.org <kernel-janitors-owner@vger.kernel.org> im Auftrag von Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Gesendet: Montag, 11. Mai 2020 12:31:24
> An: Wei Yongjun
> Cc: Hemant Kumar; Jeffrey Hugo; Greg Kroah-Hartman; Sujeev Dias; Siddartha Mohanadoss; linux-arm-msm@vger.kernel.org; kernel-janitors@vger.kernel.org; Hulk Robot
> Betreff: Re: [PATCH -next] bus: mhi: core: Fix some error return code
>
> On 0509, Wei Yongjun wrote:
> > Fix to return negative error code from the error handling case
> > instead of 0 in mhi_init_dev_ctxt() and mhi_driver_probe().
> >
> > Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> Thanks,
> Mani
>
> > ---
> > drivers/bus/mhi/core/init.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> > index eb2ab058a01d..1f8c82603179 100644
> > --- a/drivers/bus/mhi/core/init.c
> > +++ b/drivers/bus/mhi/core/init.c
> > @@ -291,6 +291,7 @@ int mhi_init_dev_ctxt(struct mhi_controller *mhi_cntrl)
> > }
> >
> > /* Setup cmd context */
> > + ret = -ENOMEM;
> > mhi_ctxt->cmd_ctxt = mhi_alloc_coherent(mhi_cntrl,
> > sizeof(*mhi_ctxt->cmd_ctxt) *
> > NR_OF_CMD_RINGS,
> > @@ -1100,6 +1101,7 @@ static int mhi_driver_probe(struct device *dev)
> > }
> > }
> >
> > + ret = -EINVAL;
> > if (dl_chan) {
> > /*
> > * If channel supports LPM notifications then status_cb should
> >
> >
> >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] bus: mhi: core: Fix some error return code
2020-05-11 14:26 ` AW: " Walter Harms
2020-05-11 14:56 ` Manivannan Sadhasivam
@ 2020-05-11 18:43 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2020-05-11 18:43 UTC (permalink / raw)
To: Walter Harms
Cc: Manivannan Sadhasivam, Wei Yongjun, Hemant Kumar, Jeffrey Hugo,
Greg Kroah-Hartman, Sujeev Dias, Siddartha Mohanadoss,
linux-arm-msm@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot
On Mon, May 11, 2020 at 02:26:10PM +0000, Walter Harms wrote:
> Hello guys,
> some nitpicking ...
> the prefered kernalstyle is:
>
> if (condition)
> set error_code
> do something
>
> from what i can see it is
>
> set error_code
> if (condition)
There isn't a prefered style. Both are accepted. Most people have a
personal preference, but there isn't an official preference.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-11 18:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-09 7:56 [PATCH -next] bus: mhi: core: Fix some error return code Wei Yongjun
2020-05-11 10:43 ` Manivannan Sadhasivam
2020-05-11 14:26 ` AW: " Walter Harms
2020-05-11 14:56 ` Manivannan Sadhasivam
2020-05-11 18:43 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).