* [PATCH] net/mlx5: E-Switch, Fix an Oops error handling code
@ 2020-06-03 17:53 Dan Carpenter
2020-06-04 5:41 ` Roi Dayan
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-06-03 17:53 UTC (permalink / raw)
To: Saeed Mahameed, Vu Pham
Cc: Leon Romanovsky, Jakub Kicinski, Mark Bloch, Parav Pandit,
Roi Dayan, linux-rdma, kernel-janitors
The error handling dereferences "vport". There is nothing we can do if
it is an error pointer except returning the error code.
Fixes: 133dcfc577ea ("net/mlx5: E-Switch, Alloc and free unique metadata for match")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c
index 4e55d7225a265..857f6193f3b14 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c
@@ -301,8 +301,7 @@ int mlx5_esw_acl_ingress_vport_bond_update(struct mlx5_eswitch *esw, u16 vport_n
if (WARN_ON_ONCE(IS_ERR(vport))) {
esw_warn(esw->dev, "vport(%d) invalid!\n", vport_num);
- err = PTR_ERR(vport);
- goto out;
+ return PTR_ERR(vport);
}
esw_acl_ingress_ofld_rules_destroy(esw, vport);
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net/mlx5: E-Switch, Fix an Oops error handling code
2020-06-03 17:53 [PATCH] net/mlx5: E-Switch, Fix an Oops error handling code Dan Carpenter
@ 2020-06-04 5:41 ` Roi Dayan
0 siblings, 0 replies; 2+ messages in thread
From: Roi Dayan @ 2020-06-04 5:41 UTC (permalink / raw)
To: Dan Carpenter, Saeed Mahameed, Vu Pham
Cc: Leon Romanovsky, Jakub Kicinski, Mark Bloch, Parav Pandit,
linux-rdma, kernel-janitors
On 2020-06-03 8:53 PM, Dan Carpenter wrote:
> The error handling dereferences "vport". There is nothing we can do if
> it is an error pointer except returning the error code.
>
> Fixes: 133dcfc577ea ("net/mlx5: E-Switch, Alloc and free unique metadata for match")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c
> index 4e55d7225a265..857f6193f3b14 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c
> @@ -301,8 +301,7 @@ int mlx5_esw_acl_ingress_vport_bond_update(struct mlx5_eswitch *esw, u16 vport_n
>
> if (WARN_ON_ONCE(IS_ERR(vport))) {
> esw_warn(esw->dev, "vport(%d) invalid!\n", vport_num);
> - err = PTR_ERR(vport);
> - goto out;
> + return PTR_ERR(vport);
> }
>
> esw_acl_ingress_ofld_rules_destroy(esw, vport);
>
thanks!
Reviewed-by: Roi Dayan <roid@mellanox.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-04 5:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-03 17:53 [PATCH] net/mlx5: E-Switch, Fix an Oops error handling code Dan Carpenter
2020-06-04 5:41 ` Roi Dayan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).