Re: [PATCH v2] drm/i915/selftest: Fix an error code in live_noa_gpr()

Lionel Landwerlin
2020-07-14T14:39:21Z

On 14/07/2020 17:36, Dan Carpenter wrote:
> The error code needs to be set on this path. It currently returns
> success.
>
> Fixes: ed2690a9ca89 ("drm/i915/selftest: Check that GPR are restored across noa_wait")
> Reported-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Fix a different bug instead. :P Colin fixed mine already.
>
> drivers/gpu/drm/i915/selftests/i915_perf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_perf.c b/drivers/gpu/drm/i915/selftests/i915_perf.c
> index 0aa151501fb3..c232194c60a2 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_perf.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_perf.c
> @@ -358,6 +358,7 @@ static int live_noa_gpr(void *arg)
> cs = intel_ring_begin(rq, 4);
> if (IS_ERR(cs)) {
> i915_request_add(rq);
> + err = PTR_ERR(cs);
> goto out_rq;
> }
>

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>