Re: [PATCH] memory: emif: Remove bogus debugfs error handling

Krzysztof Kozlowski
2020-08-27T19:35:40Z

On Wed, Aug 26, 2020 at 09:52:37AM -0700, santosh.shilimkar@oracle.com wrote:
> On 8/26/20 4:37 AM, Dan Carpenter wrote:
> > Callers are generally not supposed to check the return values from
> > debugfs functions. Debugfs functions never return NULL so this error
> > handling will never trigger. (Historically debugfs functions used to
> > return a mix of NULL and error pointers but it was eventually deemed too
> > complicated for something which wasn't intended to be used in normal
> > situations).
> >
> > Delete all the error handling.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> Looks good to me !!
>
> Acked-by: Santosh Shilimkar <ssantosh@kernel.org>

Thanks, applied.

Santosh,
Your email does not match one in ack. I understand this is just a
mistake so I put the ack. However the tool (b4-am) ignores such cases
so ack could be lost in the future.

Best regards,
Krzysztof