From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs/core: Add blank line after variable declarations.
Date: Wed, 02 Dec 2020 05:55:58 +0000 [thread overview]
Message-ID: <20201202055558.GM2767@kadam> (raw)
In-Reply-To: <20201130214749.GA381950@a>
On Tue, Dec 01, 2020 at 03:47:14PM -0600, Brother Matthew De Angelis wrote:
> Fix the checkpatch.pl warning:
>
> rtw_security.c:2374: WARNING: Missing a blank line after declarations
>
> Signed-off-by: Brother Matthew De Angelis <matthew.v.deangelis@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_security.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
> index 159d32ace2bc..a3a6558c9e03 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_security.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_security.c
> @@ -2371,6 +2371,7 @@ u8 rtw_handle_tkip_countermeasure(struct adapter *adapter, const char *caller)
>
> if (securitypriv->btkip_countermeasure) {
> unsigned long passing_ms = jiffies_to_msecs(jiffies - securitypriv->btkip_countermeasure_time);
> +
> if (passing_ms > 60*1000) {
> DBG_871X_LEVEL(_drv_always_, "%s("ADPT_FMT") countermeasure time:%lus > 60s\n",
> caller, ADPT_ARG(adapter), passing_ms/1000);
> --
> 2.25.1
>
> Hello kernel janitors,
>
> this is my third patch and I don't feel very confident yet. Would this patch be worth Greg's time?
>
I already replied about this patch earlier. Someone already sent it so
it's not needed.
These patches take about 15 seconds of Greg's time and he deliberately
leaves checkpatch warnings like this for people to practice sending him
patches.
regards,
dan carpenter
prev parent reply other threads:[~2020-12-02 5:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 21:47 [PATCH] Staging: rtl8723bs/core: Add blank line after variable declaration Brother Matthew De Angelis
2020-12-01 18:23 ` Dan Carpenter
2020-12-01 21:47 ` [PATCH] Staging: rtl8723bs/core: Add blank line after variable declarations Brother Matthew De Angelis
2020-12-02 5:55 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202055558.GM2767@kadam \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).