From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Date: Wed, 03 Feb 2021 23:04:21 +0000 Subject: Re: [PATCH] netfilter: nf_tables: remove redundant assignment of variable err Message-Id: <20210203230421.GA18404@salvia> List-Id: References: <20210128175923.645865-1-colin.king@canonical.com> In-Reply-To: <20210128175923.645865-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Jozsef Kadlecsik , Florian Westphal , "David S . Miller" , Jakub Kicinski , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Thu, Jan 28, 2021 at 05:59:23PM +0000, Colin King wrote: > From: Colin Ian King > > The variable err is being assigned a value that is never read, > the same error number is being returned at the error return > path via label err1. Clean up the code by removing the assignment. Applied to nf, thanks.