Re: [PATCH RESEND] mfd: wm831x-auxadc: Prevent use after free in wm831x_auxadc_read_irq()

Lee Jones
2021-02-04T10:37:24Z

On Fri, 29 Jan 2021, Dan Carpenter wrote:

> The "req" struct is always added to the "wm831x->auxadc_pending" list,
> but it's only removed from the list on the success path. If a failure
> occurs then the "req" struct is freed but it's still on the list,
> leading to a use after free.
>
> Fixes: 78bb3688ea18 ("mfd: Support multiple active WM831x AUXADC conversions")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
> drivers/mfd/wm831x-auxadc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Patchwork still can't find this.

I've applied it manually, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog