From: Dan Carpenter <dan.carpenter@oracle.com>
To: Edmundo Carmona Antoranz <eantoranz@gmail.com>
Cc: gregkh@linuxfoundation.org, marcocesati@gmail.com,
ross.schm.dev@gmail.com, fabioaiuto83@gmail.com,
linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next 6/6] staging: rtl8723bs: sta_mgt: return _FAIL if there is an error
Date: Sat, 27 Mar 2021 11:21:06 +0300 [thread overview]
Message-ID: <20210327082105.GK1667@kadam> (raw)
In-Reply-To: <20210327001736.180881-6-eantoranz@gmail.com>
On Fri, Mar 26, 2021 at 06:17:36PM -0600, Edmundo Carmona Antoranz wrote:
> If there is an error when calling rtw_init_bcmc_stainfo() inside
> rtw_init_bcmc_stainfo(), variable res is set to _FAIL. However, when
> returning, _SUCCESS is always returned regardless. Just in case,
> all existing calls do not consider the result of the function.
This more papering over badness. Lets leave it as-is until someone can
fix the callers. Static checkers are useful things but if we silence
the warnings without fixing the bugs then we are basically going to
great effort to write a checker and even more effort to disable the
checker.
regards,
dan carpenter
next prev parent reply other threads:[~2021-03-27 8:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 0:17 [PATCH -next 1/6] staging: rtl8723bs: ieee80211: remove unused variable Edmundo Carmona Antoranz
2021-03-27 0:17 ` [PATCH -next 2/6] staging: rtl8723bs: mlme: remove unused variables Edmundo Carmona Antoranz
2021-03-28 12:33 ` Greg KH
2021-03-27 0:17 ` [PATCH -next 3/6] staging: rtl8723bs: hal: remove unused variable in HalBtc8723b1Ant.c Edmundo Carmona Antoranz
2021-03-27 0:17 ` [PATCH -next 4/6] staging: rtl8723bs: sdio_ops: removing unused variable Edmundo Carmona Antoranz
2021-03-27 0:17 ` [PATCH -next 5/6] staging: rtl8723bs: mark some variables as __maybe_unused Edmundo Carmona Antoranz
2021-03-27 8:17 ` Dan Carpenter
2021-03-27 14:44 ` Edmundo Carmona Antoranz
2021-03-27 16:27 ` Dan Carpenter
2021-03-27 0:17 ` [PATCH -next 6/6] staging: rtl8723bs: sta_mgt: return _FAIL if there is an error Edmundo Carmona Antoranz
2021-03-27 0:23 ` Edmundo Carmona Antoranz
2021-03-27 8:21 ` Dan Carpenter [this message]
2021-03-27 8:13 ` [PATCH -next 1/6] staging: rtl8723bs: ieee80211: remove unused variable Dan Carpenter
2021-03-28 12:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210327082105.GK1667@kadam \
--to=dan.carpenter@oracle.com \
--cc=eantoranz@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
--cc=ross.schm.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).