Re: [PATCH 6/6] staging: rtl8188eu: use safe iterator in rtw_free_xmitframe_queue

Guenter Roeck
2021-05-16T19:25:03Z

On Sun, May 16, 2021 at 06:06:13PM +0200, Martin Kaiser wrote:
> Use list_for_each_safe, we may delete list items while iterating over
> the list.
>
> Fixes: 23017c8842d2 ("staging: rtl8188eu: Use list iterators and helpers")
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> compile-tested only
>
> drivers/staging/rtl8188eu/core/rtw_xmit.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c
> index 3763d188b892..62b8f178280e 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
> @@ -1329,13 +1329,13 @@ s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_frame *pxmitfram
>
> void rtw_free_xmitframe_queue(struct xmit_priv *pxmitpriv, struct __queue *pframequeue)
> {
> - struct list_head *plist, *phead;
> + struct list_head *plist, *phead, *temp;
> struct xmit_frame *pxmitframe;
>
> spin_lock_bh(&pframequeue->lock);
>
> phead = get_list_head(pframequeue);
> - list_for_each(plist, phead) {
> + list_for_each_safe(plist, temp, phead) {
> pxmitframe = list_entry(plist, struct xmit_frame, list);
>
> rtw_free_xmitframe(pxmitpriv, pxmitframe);
> --
> 2.20.1
>