Re: [PATCH] scsi: libsas: use _safe() loop in sas_resume_port()

John Garry
2021-05-19T14:49:37Z

On 19/05/2021 15:20, Dan Carpenter wrote:
> If sas_notify_lldd_dev_found() fails then this code calls:
>
> sas_unregister_dev(port, dev);
>
> which removes "dev", our list iterator, from the list. This could
> lead to an endless loop. We need to use list_for_each_entry_safe().
>
> Fixes: 303694eeee5e ("[SCSI] libsas: suspend / resume support")
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>

Reviewed-by: John Garry <john.garry@huawei.com>