From: Jonathan Cameron <jic23@kernel.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Alexandru Ardelean <alexandru.ardelean@analog.com>,
<linux-iio@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] iio: dummy: Fix build error when CONFIG_IIO_TRIGGERED_BUFFER is not set
Date: Wed, 26 May 2021 18:00:18 +0100 [thread overview]
Message-ID: <20210526180018.66ac9989@jic23-huawei> (raw)
In-Reply-To: <20210524140536.116224-1-weiyongjun1@huawei.com>
On Mon, 24 May 2021 14:05:36 +0000
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> Gcc reports build error when CONFIG_IIO_TRIGGERED_BUFFER is not set:
>
> riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `iio_simple_dummy_configure_buffer':
> iio_simple_dummy_buffer.c:(.text+0x2b0): undefined reference to `iio_triggered_buffer_setup_ext'
> riscv64-linux-gnu-ld: drivers/iio/dummy/iio_simple_dummy_buffer.o: in function `.L0 ':
> iio_simple_dummy_buffer.c:(.text+0x2fc): undefined reference to `iio_triggered_buffer_cleanup'
>
> Fix it by select IIO_TRIGGERED_BUFFER for config IIO_SIMPLE_DUMMY_BUFFER.
>
> Fixes: 738f6ba11800 ("iio: dummy: iio_simple_dummy_buffer: use triggered buffer core calls")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks,
Applied to the fixes-togreg branch of iio.git.
Jonathan
> ---
> drivers/iio/dummy/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/dummy/Kconfig b/drivers/iio/dummy/Kconfig
> index 5c5c2f8c55f3..1f46cb9e51b7 100644
> --- a/drivers/iio/dummy/Kconfig
> +++ b/drivers/iio/dummy/Kconfig
> @@ -34,6 +34,7 @@ config IIO_SIMPLE_DUMMY_BUFFER
> select IIO_BUFFER
> select IIO_TRIGGER
> select IIO_KFIFO_BUF
> + select IIO_TRIGGERED_BUFFER
> help
> Add buffered data capture to the simple dummy driver.
>
>
next prev parent reply other threads:[~2021-05-26 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 14:05 [PATCH -next] iio: dummy: Fix build error when CONFIG_IIO_TRIGGERED_BUFFER is not set Wei Yongjun
2021-05-26 17:00 ` Jonathan Cameron [this message]
2021-06-11 17:31 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526180018.66ac9989@jic23-huawei \
--to=jic23@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox