From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34A4FC48BCD for ; Wed, 9 Jun 2021 10:36:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0399E61185 for ; Wed, 9 Jun 2021 10:36:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236142AbhFIKin (ORCPT ); Wed, 9 Jun 2021 06:38:43 -0400 Received: from mail-ot1-f53.google.com ([209.85.210.53]:37784 "EHLO mail-ot1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234105AbhFIKin (ORCPT ); Wed, 9 Jun 2021 06:38:43 -0400 Received: by mail-ot1-f53.google.com with SMTP id 102-20020a9d0eef0000b02903fccc5b733fso424711otj.4 for ; Wed, 09 Jun 2021 03:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nXjAuhIXVZyPoeUrx9siagzmPu5Az50EDvyRWCnxxEs=; b=vJUYsXfPYovu+iz92/RvEugJMis+Z74dcHYMkyuFPVVUY+ihNB6sIRRC6n5r7KKUPN hvL7QPZZOKtC8jywEV/il/VwfLqAdi6KCjmyp09NPeK83PbqJW7Zs+WsYWqIh+p3HZIU 3mdFsIB2GEH+VN6yINY2vqAawKt+KTXYVcGFNGlD9ESEkkGV1Vc9nlYpFkjvQV2rXM5/ Kan4Nel/06PJyxvH0X/BPS5GrwO7knuoncGBZ/2hbEhBcwgKZPbbgp7TRdv3Fq7MtEnR 43GVJqFoDOPiABq/piL3ns2FLRkSKGA9qJAyRPMNPeXuZI5kn4yHbE4FInCMNmNJCx0P lalQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=nXjAuhIXVZyPoeUrx9siagzmPu5Az50EDvyRWCnxxEs=; b=FEfEutmSY0x70/ve2XoDgJRN7B9QXFHSIjXxxpMUSvbYbhZ6RRnDmOONwLykqpqcTm Kkq5Ge/EPPcdqW5Z4E1kqfXwTB2p8EivcL6cS9lTmSgwlJkKKT0c7qesasMN3ktnFMok LcrwMwarXgOGL72OcnJ/vDPuhspqq9i3K3sr3ynCLNqamRBMrzBzjd/n8Pb1yg9mBCYM Lru6fZnbEo5yU1cD0x1eqqreLxq9GafDQ8CpuUSlIGw0uJhdtThgWGHQZP2sr0BbwRxk XWcawGueFcSYtVGdOj6ZvAzTIQ8k9dU+KZc+qucEhjCAYJwIOey0v7uxUHvWsI8oqa+I M0+w== X-Gm-Message-State: AOAM531BfTHuMyB253xlmyiWcN6pQIafdynZZ1Oe6tgJSun7/ffWqf/x 9WW4NkfjQXTVXkrjK7Hf9mA= X-Google-Smtp-Source: ABdhPJxc33QJQ47j1RA0Uzk0RejGgy47Gq7IdPphMuDwbKmUOIqVmxpRd5JBCW4ctNcQocuO53LIIQ== X-Received: by 2002:a05:6830:3115:: with SMTP id b21mr21296441ots.234.1623234948977; Wed, 09 Jun 2021 03:35:48 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id q1sm3351988oos.32.2021.06.09.03.35.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 03:35:48 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 9 Jun 2021 03:35:47 -0700 From: Guenter Roeck To: Dan Carpenter Cc: Larry Finger , Greg Kroah-Hartman , Martin Kaiser , Ivan Safonov , Deborah Brouwer , Simon Fong , Michael Straube , linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/7] staging: rtl8188eu: use safe iterator in dequeue_xmitframes_to_sleeping_queue() Message-ID: <20210609103547.GC3727184@roeck-us.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Mon, Jun 07, 2021 at 09:17:43PM +0300, Dan Carpenter wrote: > On some code paths the xmitframe_enqueue_for_sleeping_sta() function can > call list_del_init(&pxmitframe->list) which would lead to a forever loop > because "pxmitframe" is the list iterator. Use the _safe version of the > iterator to prevent this. > > Fixes: 23017c8842d2 ("staging: rtl8188eu: Use list iterators and helpers") > Signed-off-by: Dan Carpenter Reviewed-by: Guenter Roeck > --- > drivers/staging/rtl8188eu/core/rtw_xmit.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c > index dcc29a74612d..f57e41f817ca 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_xmit.c > +++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c > @@ -1729,17 +1729,15 @@ int xmitframe_enqueue_for_sleeping_sta(struct adapter *padapter, struct xmit_fra > > static void dequeue_xmitframes_to_sleeping_queue(struct adapter *padapter, struct sta_info *psta, struct __queue *pframequeue) > { > - struct list_head *plist, *phead; > + struct list_head *phead; > u8 ac_index; > struct tx_servq *ptxservq; > struct pkt_attrib *pattrib; > - struct xmit_frame *pxmitframe; > + struct xmit_frame *pxmitframe, *n; > struct hw_xmit *phwxmits = padapter->xmitpriv.hwxmits; > > phead = get_list_head(pframequeue); > - list_for_each(plist, phead) { > - pxmitframe = list_entry(plist, struct xmit_frame, list); > - > + list_for_each_entry_safe(pxmitframe, n, phead, list) { > xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe); > > pattrib = &pxmitframe->attrib; > -- > 2.30.2 >