[PATCH][next] vfio/mdpy: Fix memory leak of object mdev_state->vconfig

Colin King
2021-06-22T18:37:15Z

From: Colin Ian King <colin.king@canonical.com>

In the case where the call to vfio_register_group_dev fails the error
return path kfree's mdev_state but not mdev_state->vconfig. Fix this
by kfree'ing mdev_state->vconfig before returning.

Addresses-Coverity: ("Resource leak")
Fixes: 437e41368c01 ("vfio/mdpy: Convert to use vfio_register_group_dev()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
samples/vfio-mdev/mdpy.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/samples/vfio-mdev/mdpy.c b/samples/vfio-mdev/mdpy.c
index 7e9c9df0f05b..393c9df6f6a0 100644
--- a/samples/vfio-mdev/mdpy.c
+++ b/samples/vfio-mdev/mdpy.c
@@ -261,6 +261,7 @@ static int mdpy_probe(struct mdev_device *mdev)

ret = vfio_register_group_dev(&mdev_state->vdev);
if (ret) {
+ kfree(mdev_state->vconfig);
kfree(mdev_state);
return ret;
}
--
2.31.1