[PATCH 0/9] Kconfig symbol clean-up on ./arch/x86/

Lukas Bulwahn
2021-08-03T11:36:01Z

Dear x86 maintainers,

Randy Dunlap pointed out that ./scripts/checkkconfigsymbols.py warns on
invalid references to Kconfig symbols (often, minor typos, name confusions
or outdated references): see Link below.

This is a first patch series addressing the issues reported by
./scripts/checkkconfigsymbols.py in the ./arch/x86/ directories, quickly
filtered down with:

./scripts/checkkconfigsymbols.py | grep "arch/x86" -B 1 -A 2

It addresses some issues I considered to be "true positives";
so, issues that should be addressed and cleaned up.

The patches on updating the comments might arguably be considered of low
value by itself, but as the other patches show, checkkconfigsymbols does
detect some relevant issues in the kernel tree otherwise being unnoticed.
So, it might be worth to clean up the kernel tree to have checkkconfigsymbols
produce a rather short list of issues and then continuously follow and check
what checkkconfigsymbols reports.

Some work from checkkconfigsymbols on arch/x86 is deferred:

- OSNOISE_TRAECR typo in arch/x86/kernel/trace.c
This will added to a separate janitor cleanup series with other topics
on this file.

- a reference to STRICT_IOMEM in arch/x86/mm/init.c
unclear to me: which exact config this refers to

- Given some updates of the minimal version for binutils (now >= 2.23),
the whole special detection of binutils support for CONFIG_X86_X32 and
its speciality with CONFIG_X86_X32_ABI might be unneeded. I might look
into that in a separate task.

The remaining issues that checkkconfigsymbols reports are (as far as I
understand it now) "false positives" (the tool misinterprets the actual
content) or "intentional", e.g., they refer to historic configs for the
purpose of documentation (e.g., in changelogs) or are in various kernel
configs that are not continuously updated to match the current set of
kernel configs.

Please pick this series of minor clean-up patches on ./arch/x86/.

It applies cleanly on next-20210802.

Link: https://lore.kernel.org/linux-kernel-mentees/295b8f8c-4264-9f32-6723-9d2d574021ac@infradead.org/

Best regards,

Lukas

Lukas Bulwahn (9):
x86/entry: correct reference to intended CONFIG_64_BIT
x86, olpc: correct condition to intended CONFIG_OLPC_XO15_SCI
x86/Kconfig: correct reference to MWINCHIP3D
x86/Kconfig: remove reference to obsolete MFD_INTEL_MSIC config
x86/Kconfig: remove reference to obsolete APB_TIMER config
x86/irq: fix slightly wrong reference in comment
x86/uaccess: adjust comment for endif of CONFIG_CC_HAS_ASM_GOTO_OUTPUT
x86: page_32.h: adjust comment for endif of CONFIG_X86_USE_3DNOW
x86: ia32.h: adjust comment for endif of CONFIG_IA32_EMULATION

arch/x86/Kconfig | 4 +---
arch/x86/include/asm/entry-common.h | 2 +-
arch/x86/include/asm/ia32.h | 2 +-
arch/x86/include/asm/irq_stack.h | 2 +-
arch/x86/include/asm/page_32.h | 2 +-
arch/x86/include/asm/uaccess.h | 2 +-
arch/x86/platform/olpc/olpc.c | 2 +-
7 files changed, 7 insertions(+), 9 deletions(-)

--
2.17.1