From: Mark Brown <broonie@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: "Robin Murphy" <robin.murphy@arm.com>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Simon Xue" <xxm@rock-chips.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Kever Yang" <kever.yang@rock-chips.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
PCI <linux-pci@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PCI: rockchip-dwc: Potential error pointer dereference in probe
Date: Fri, 13 Aug 2021 17:01:16 +0100 [thread overview]
Message-ID: <20210813160116.GE5209@sirena.org.uk> (raw)
In-Reply-To: <CAL_JsqLWVLRDdkR62BSv69oW3QCLVebgpU1TKtxvzZmD4wuP4Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
On Fri, Aug 13, 2021 at 10:57:44AM -0500, Rob Herring wrote:
> On Fri, Aug 13, 2021 at 8:47 AM Robin Murphy <robin.murphy@arm.com> wrote:
> > In fact it's the other way round - "optional" in this case is for when
> > the supply may legitimately not exist so the driver may or may not need
> > to handle it, so it can return -ENODEV if a regulator isn't described by
> > firmware. A non-optional regulator is assumed to represent a necessary
> > supply, so if there's nothing described by firmware you get the (valid)
> > dummy regulator back.
> Ah yes, regulators is the oddball. Surely no one else will assume the
> same behavior of _optional() variants across subsystems... ;)
It would be silly to copy the *whole* pattern!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-08-13 16:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 11:33 [PATCH] PCI: rockchip-dwc: Potential error pointer dereference in probe Dan Carpenter
2021-08-13 12:55 ` Robin Murphy
2021-08-13 13:34 ` Rob Herring
2021-08-13 13:47 ` Robin Murphy
2021-08-13 15:57 ` Rob Herring
2021-08-13 16:01 ` Mark Brown [this message]
2021-08-13 13:54 ` Dan Carpenter
2021-08-13 14:01 ` Robin Murphy
2021-08-13 14:12 ` Dan Carpenter
2021-08-13 14:26 ` [PATCH v2] " Dan Carpenter
2021-08-23 16:15 ` Lorenzo Pieralisi
2021-08-13 14:32 ` [PATCH] " Mark Brown
2021-08-13 15:00 ` Robin Murphy
2021-08-13 15:30 ` Mark Brown
2021-08-13 15:45 ` Dan Carpenter
2021-08-13 15:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210813160116.GE5209@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bhelgaas@google.com \
--cc=dan.carpenter@oracle.com \
--cc=heiko@sntech.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=kever.yang@rock-chips.com \
--cc=kw@linux.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=shawn.lin@rock-chips.com \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox