From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 000B4C4320E for ; Sun, 29 Aug 2021 15:53:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CED6660F45 for ; Sun, 29 Aug 2021 15:53:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235762AbhH2Pyd (ORCPT ); Sun, 29 Aug 2021 11:54:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:41664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235738AbhH2Pyc (ORCPT ); Sun, 29 Aug 2021 11:54:32 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E772E60F42; Sun, 29 Aug 2021 15:53:37 +0000 (UTC) Date: Sun, 29 Aug 2021 16:56:53 +0100 From: Jonathan Cameron To: Dan Carpenter Cc: Sean Nyekjaer , Lars-Peter Clausen , Vincent Whitchurch , linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] iio: dac: fix an error code in probe() Message-ID: <20210829165653.36c65f7c@jic23-huawei> In-Reply-To: <20210816183954.GB2068@kili> References: <20210816183954.GB2068@kili> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Mon, 16 Aug 2021 21:39:54 +0300 Dan Carpenter wrote: > If we have an unexpected number of channels then return -EINVAL instead > of returning success. > > Fixes: df38a4a72a3b ("iio: dac: add TI DAC5571 family support") > Signed-off-by: Dan Carpenter Given I'm not going to be doing another fixes pull for 5.14 (bit late afterall!) I've rebased the fixes-togreg branch to match staging/staging-next which will go in during the merge window + applied this on top. Thanks, Jonathan > --- > drivers/iio/dac/ti-dac5571.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/dac/ti-dac5571.c b/drivers/iio/dac/ti-dac5571.c > index 2a5ba1b08a1d..546a4cf6c5ef 100644 > --- a/drivers/iio/dac/ti-dac5571.c > +++ b/drivers/iio/dac/ti-dac5571.c > @@ -350,6 +350,7 @@ static int dac5571_probe(struct i2c_client *client, > data->dac5571_pwrdwn = dac5571_pwrdwn_quad; > break; > default: > + ret = -EINVAL; > goto err; > } >