Re: [PATCH] EDAC/device: Remove redundant initialization of pointer dev_ctl

Dan Carpenter
2021-09-07T12:56:52Z

On Tue, Sep 07, 2021 at 11:59:13AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable dev_ctl is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/edac/edac_device.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c
> index 8c4d947fb848..a337f7afc3b9 100644
> --- a/drivers/edac/edac_device.c
> +++ b/drivers/edac/edac_device.c
> @@ -75,7 +75,6 @@ struct edac_device_ctl_info *edac_device_alloc_ctl_info(
> * provide if we could simply hardcode everything into a single struct.
> */
> p = NULL;
> - dev_ctl = edac_align_ptr(&p, sizeof(*dev_ctl), 1);
^^
This sets "p" up for the next call so I think it's required.

regards,
dan carpenter