Re: [PATCH net] nfc: avoid potential race condition

Jakub Kicinski
2021-09-27T14:26:07Z

On Mon, 27 Sep 2021 09:44:08 +0200 Krzysztof Kozlowski wrote:
> On 24/09/2021 22:14, Jakub Kicinski wrote:
> > On Fri, 24 Sep 2021 10:21:33 +0200 Krzysztof Kozlowski wrote:
> >> Indeed. The code looks reasonable, though, so even if race is not really
> >> reproducible:
> >>
> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >
> > Would you mind making a call if this is net (which will mean stable) or
> > net-next material (without the Fixes tags) and reposting? Thanks! :)
>
> Hi Jakub,
>
> Material is net-next. However I don't understand why it should be
> without "Fixes" in such case?
>
> The material going to current release (RC, so I understood: net), should
> fix only issues introduced in current merge window. Linus made it clear
> several times.

Oh, really? I've never heard about this rule, would you be able to dig
up references?

This strikes me as odd, most fixes we merge are for previous releases.
In fact when I write -rc pull requests to Linus I break them down by
current release vs previous - and he never complained.

> The issue here was introduced long time ago, not in current merge
> window, however it is still an issue to fix. It's still a bug which
> should have a commit with "Fixes" for all the stable tress and
> downstream distros relying on stable kernels. Also for some statistics
> on LWN.

Stable will not pull the commit from net-next, tho. Stable is more
restrictive than rc (or at least so I think) so "we want it in stable,
please merge it to net-next" does not compute with the preconceptions
I have.