From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Colin Ian King <colin.i.king@googlemail.com>
Cc: William Hubbs <w.d.hubbs@gmail.com>,
Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
speakup@linux-speakup.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] speakup: remove redundant assignment of variable i
Date: Thu, 11 Nov 2021 00:35:09 +0100 [thread overview]
Message-ID: <20211110233509.rt5ioflkym4a6tya@begin> (raw)
In-Reply-To: <20211110233342.1372516-1-colin.i.king@gmail.com>
Colin Ian King, le mer. 10 nov. 2021 23:33:42 +0000, a ecrit:
> The variable i is being initialized a value that is never read, it is
> re-assigned later on in a for-loop. The assignment is redundant and
> can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> V2: Use correct SoB
> ---
> drivers/accessibility/speakup/speakup_acntpc.c | 2 +-
> drivers/accessibility/speakup/speakup_dtlk.c | 2 +-
> drivers/accessibility/speakup/speakup_keypc.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/accessibility/speakup/speakup_acntpc.c b/drivers/accessibility/speakup/speakup_acntpc.c
> index c1ec087dca13..023172ca22ef 100644
> --- a/drivers/accessibility/speakup/speakup_acntpc.c
> +++ b/drivers/accessibility/speakup/speakup_acntpc.c
> @@ -247,7 +247,7 @@ static void synth_flush(struct spk_synth *synth)
> static int synth_probe(struct spk_synth *synth)
> {
> unsigned int port_val = 0;
> - int i = 0;
> + int i;
>
> pr_info("Probing for %s.\n", synth->long_name);
> if (port_forced) {
> diff --git a/drivers/accessibility/speakup/speakup_dtlk.c b/drivers/accessibility/speakup/speakup_dtlk.c
> index 92838d3ae9eb..a9dd5c45d237 100644
> --- a/drivers/accessibility/speakup/speakup_dtlk.c
> +++ b/drivers/accessibility/speakup/speakup_dtlk.c
> @@ -316,7 +316,7 @@ static struct synth_settings *synth_interrogate(struct spk_synth *synth)
> static int synth_probe(struct spk_synth *synth)
> {
> unsigned int port_val = 0;
> - int i = 0;
> + int i;
> struct synth_settings *sp;
>
> pr_info("Probing for DoubleTalk.\n");
> diff --git a/drivers/accessibility/speakup/speakup_keypc.c b/drivers/accessibility/speakup/speakup_keypc.c
> index 311f4aa0be22..1618be87bff1 100644
> --- a/drivers/accessibility/speakup/speakup_keypc.c
> +++ b/drivers/accessibility/speakup/speakup_keypc.c
> @@ -254,7 +254,7 @@ static void synth_flush(struct spk_synth *synth)
> static int synth_probe(struct spk_synth *synth)
> {
> unsigned int port_val = 0;
> - int i = 0;
> + int i;
>
> pr_info("Probing for %s.\n", synth->long_name);
> if (port_forced) {
> --
> 2.32.0
>
prev parent reply other threads:[~2021-11-10 23:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 23:33 [PATCH][V2] speakup: remove redundant assignment of variable i Colin Ian King
2021-11-10 23:35 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110233509.rt5ioflkym4a6tya@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=chris@the-brannons.com \
--cc=colin.i.king@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox