From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
Xie Yongji <xieyongji@bytedance.com>, Eli Cohen <elic@nvidia.com>,
Parav Pandit <parav@nvidia.com>,
virtualization@lists.linux-foundation.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] vduse: vduse: fix memory corruption in vduse_dev_ioctl()
Date: Tue, 7 Dec 2021 14:48:05 +0300 [thread overview]
Message-ID: <20211207114805.GJ1978@kadam> (raw)
In-Reply-To: <20211207112146.GA27784@kili>
On Tue, Dec 07, 2021 at 02:21:46PM +0300, Dan Carpenter wrote:
> The "config.offset" comes from the user. There needs to a check to
> prevent it being out of bounds. The "config.offset" and
> "dev->config_size" variables are both type u32. So if the offset if
> out of bounds then the "dev->config_size - config.offset" subtraction
> results in a very high u32 value.
>
> Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: version 1 had a reversed if statement
Xie Yongji pointed out that vhost_vdpa_config_validate() had a similar
issue so I'll send a v3.
regards,
dan carpenter
prev parent reply other threads:[~2021-12-07 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 11:21 [PATCH v2] vduse: vduse: fix memory corruption in vduse_dev_ioctl() Dan Carpenter
2021-12-07 11:48 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211207114805.GJ1978@kadam \
--to=dan.carpenter@oracle.com \
--cc=elic@nvidia.com \
--cc=jasowang@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox