* [PATCH] ata: pata_atiixp: make static read-only arrays const
@ 2022-01-23 22:16 Colin Ian King
2022-01-24 17:18 ` Sergei Shtylyov
2022-01-27 23:35 ` Damien Le Moal
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2022-01-23 22:16 UTC (permalink / raw)
To: Damien Le Moal, linux-ide; +Cc: kernel-janitors, linux-kernel
The static arrays pio_timings and mwdma_timings are read-only so
it make sense to make them const.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/ata/pata_atiixp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_atiixp.c b/drivers/ata/pata_atiixp.c
index c3a65ccd4b79..efdb94cff68b 100644
--- a/drivers/ata/pata_atiixp.c
+++ b/drivers/ata/pata_atiixp.c
@@ -102,7 +102,7 @@ static int atiixp_prereset(struct ata_link *link, unsigned long deadline)
static void atiixp_set_pio_timing(struct ata_port *ap, struct ata_device *adev, int pio)
{
- static u8 pio_timings[5] = { 0x5D, 0x47, 0x34, 0x22, 0x20 };
+ static const u8 pio_timings[5] = { 0x5D, 0x47, 0x34, 0x22, 0x20 };
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
int dn = 2 * ap->port_no + adev->devno;
@@ -149,7 +149,7 @@ static void atiixp_set_piomode(struct ata_port *ap, struct ata_device *adev)
static void atiixp_set_dmamode(struct ata_port *ap, struct ata_device *adev)
{
- static u8 mwdma_timings[5] = { 0x77, 0x21, 0x20 };
+ static const u8 mwdma_timings[5] = { 0x77, 0x21, 0x20 };
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
int dma = adev->dma_mode;
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ata: pata_atiixp: make static read-only arrays const
2022-01-23 22:16 [PATCH] ata: pata_atiixp: make static read-only arrays const Colin Ian King
@ 2022-01-24 17:18 ` Sergei Shtylyov
2022-01-27 23:35 ` Damien Le Moal
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2022-01-24 17:18 UTC (permalink / raw)
To: Colin Ian King, Damien Le Moal, linux-ide; +Cc: kernel-janitors, linux-kernel
On 1/24/22 1:16 AM, Colin Ian King wrote:
> The static arrays pio_timings and mwdma_timings are read-only so
> it make sense to make them const.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ata: pata_atiixp: make static read-only arrays const
2022-01-23 22:16 [PATCH] ata: pata_atiixp: make static read-only arrays const Colin Ian King
2022-01-24 17:18 ` Sergei Shtylyov
@ 2022-01-27 23:35 ` Damien Le Moal
1 sibling, 0 replies; 3+ messages in thread
From: Damien Le Moal @ 2022-01-27 23:35 UTC (permalink / raw)
To: Colin Ian King, linux-ide; +Cc: kernel-janitors, linux-kernel
On 1/24/22 07:16, Colin Ian King wrote:
> The static arrays pio_timings and mwdma_timings are read-only so
> it make sense to make them const.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Applied to for-5.18. Thanks !
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-27 23:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-23 22:16 [PATCH] ata: pata_atiixp: make static read-only arrays const Colin Ian King
2022-01-24 17:18 ` Sergei Shtylyov
2022-01-27 23:35 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).