From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: delete shadow "ret" variable
Date: Fri, 28 Jan 2022 09:36:44 +0300 [thread overview]
Message-ID: <20220128063644.GH1978@kadam> (raw)
In-Reply-To: <f8044efa53f2ea6f998a08592343c9a8f952c718.camel@linux.intel.com>
On Fri, Jan 28, 2022 at 07:20:02AM +0100, Thomas Hellström wrote:
> On Thu, 2022-01-27 at 17:26 -0500, Rodrigo Vivi wrote:
> > On Thu, Jan 27, 2022 at 11:51:15AM +0300, Dan Carpenter wrote:
> > > This "ret" declaration shadows an existing "ret" variable at the
> > > top of
> > > the function. Delete it.
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >
> > and pushing right now
>
> Should probably have had a Fixes: tag on this one. I'm not 100% sure
> whether the faulty patch is already upstream. In that case we might
> need to manually include it in a -fixes pull.
>
It's not really a bug. It's just a Sparse warning which is disabled
by default (-Wshadow). The patch is in linux-next.
Fixes: 2f6b90da9192 ("drm/i915: Use vma resources for async unbinding")
regards,
dan carpenter
next prev parent reply other threads:[~2022-01-28 6:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 8:51 [PATCH] drm/i915: delete shadow "ret" variable Dan Carpenter
2022-01-27 22:26 ` [Intel-gfx] " Rodrigo Vivi
2022-01-28 6:20 ` Thomas Hellström
2022-01-28 6:36 ` Dan Carpenter [this message]
2022-01-28 13:50 ` Vivi, Rodrigo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128063644.GH1978@kadam \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).