From: Dan Carpenter <dan.carpenter@oracle.com>
To: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH 1/2] ASoC: ops: fix signedness bug in snd_soc_put_volsw()
Date: Fri, 28 Jan 2022 14:20:07 +0300 [thread overview]
Message-ID: <20220128112007.GA24806@kili> (raw)
The "val" and "val2" variables need to signed for the checking to work
as intended.
Fixes: 817f7c9335ec ("ASoC: ops: Reject out of bounds values in snd_soc_put_volsw()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
sound/soc/soc-ops.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/soc/soc-ops.c b/sound/soc/soc-ops.c
index dc0e7c8d31f3..0091fa96eb48 100644
--- a/sound/soc/soc-ops.c
+++ b/sound/soc/soc-ops.c
@@ -310,8 +310,9 @@ int snd_soc_put_volsw(struct snd_kcontrol *kcontrol,
unsigned int invert = mc->invert;
int err;
bool type_2r = false;
- unsigned int val2 = 0;
- unsigned int val, val_mask;
+ unsigned int val_mask;
+ int val2 = 0;
+ int val;
if (sign_bit)
mask = BIT(sign_bit + 1) - 1;
--
2.20.1
next reply other threads:[~2022-01-28 11:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 11:20 Dan Carpenter [this message]
2022-01-28 11:20 ` [PATCH 2/2] ASoC: ops: Fix signedness bug in snd_soc_put_volsw_sx() Dan Carpenter
2022-01-28 12:42 ` [PATCH 1/2] ASoC: ops: fix signedness bug in snd_soc_put_volsw() Mark Brown
2022-01-28 13:31 ` Dan Carpenter
2022-01-28 13:48 ` Mark Brown
2022-01-28 14:05 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128112007.GA24806@kili \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).