From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Takashi Iwai <tiwai@suse.de>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Clemens Ladisch <clemens@ladisch.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ALSA: firewire-digi00x: prevent potential use after free
Date: Fri, 12 May 2023 22:44:14 +0900 [thread overview]
Message-ID: <20230512134414.GA913159@workstation> (raw)
In-Reply-To: <873542aro1.wl-tiwai@suse.de>
Hi,
On Fri, May 12, 2023 at 10:18:54AM +0200, Takashi Iwai wrote:
> On Tue, 09 May 2023 11:07:11 +0200,
> Dan Carpenter wrote:
> >
> > This code was supposed to return an error code if init_stream()
> > failed, but it instead freed dg00x->rx_stream and returned success.
> > This potentially leads to a use after free.
> >
> > Fixes: 9a08067ec318 ("ALSA: firewire-digi00x: support AMDTP domain")
> > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>
> Thanks, applied now.
I overlooked the patch. It looks good to me as well.
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Thanks
Takashi Sakamoto
prev parent reply other threads:[~2023-05-12 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 9:07 [PATCH] ALSA: firewire-digi00x: prevent potential use after free Dan Carpenter
2023-05-12 8:18 ` Takashi Iwai
2023-05-12 13:44 ` Takashi Sakamoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230512134414.GA913159@workstation \
--to=o-takashi@sakamocchi.jp \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox