From: "Krzysztof Wilczyński" <kw@linux.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Xiaowei Song <songxiaowei@hisilicon.com>,
Binghui Wang <wangbinghui@hisilicon.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI: kirin: Use devm_kasprintf()
Date: Sun, 17 Dec 2023 12:08:50 +0900 [thread overview]
Message-ID: <20231217030850.GA1150418@rocinante> (raw)
In-Reply-To: <1bad6879083a7d836c8a47418a0afa22485e8f69.1700294127.git.christophe.jaillet@wanadoo.fr>
Hello,
> Use devm_kasprintf() instead of hand writing it.
> This saves the need of an intermediate buffer.
>
> There was also no reason to use the _const() version of devm_kstrdup().
> The string was known be not constant.
Applied to controller/kirin, thank you!
[1/1] PCI: kirin: Use devm_kasprintf() to dynamically allocate clock names
https://git.kernel.org/pci/pci/c/9f5077ef8f81
Krzysztof
prev parent reply other threads:[~2023-12-17 3:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 7:55 [PATCH v2] PCI: kirin: Use devm_kasprintf() Christophe JAILLET
2023-12-17 3:08 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231217030850.GA1150418@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
--cc=songxiaowei@hisilicon.com \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox