From: Alex Williamson <alex.williamson@redhat.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Eric Auger <eric.auger@redhat.com>,
kvm@vger.kernel.org, kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: vfio/platform: Use common error handling code in vfio_set_trigger()
Date: Tue, 16 Jan 2024 11:33:08 -0700 [thread overview]
Message-ID: <20240116113308.78935e11.alex.williamson@redhat.com> (raw)
In-Reply-To: <ab6bcd8b-f53c-47d1-8c55-c374a36d6ee4@web.de>
On Tue, 16 Jan 2024 12:32:23 +0100
Markus Elfring <Markus.Elfring@web.de> wrote:
> > TBH, this doesn't seem like a worthwhile exit point consolidation. A
> > change like this might be justified if there were some common unlock
> > code that could be shared, but for a simple free and return errno by
> > jumping to a different exception block, rather than even a common exit
> > block, I don't see the value.
>
> Can it be helpful to store the shown kfree() call only once
> in this function implementation?
I don't believe it's worthwhile, it's a simple function with simple
exit paths and consolidating those exit paths for a trivial kfree() is
unnecessarily complex. Thanks,
Alex
prev parent reply other threads:[~2024-01-16 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 17:16 [PATCH] vfio/platform: Use common error handling code in vfio_set_trigger() Markus Elfring
2024-01-15 20:37 ` Alex Williamson
2024-01-16 11:32 ` Markus Elfring
2024-01-16 18:33 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116113308.78935e11.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=Markus.Elfring@web.de \
--cc=eric.auger@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox