[PATCH v2 1/1] [net-next] igb: Fix spelling in igb_main.c

[PATCH v2 1/1] [net-next] igb: Fix spelling in igb_main.c

[Johnny Park]

Simple patch that fix spelling mistakes in igb_main.c

Signed-off-by: Johnny Park <pjohnny0508@gmail.com>
---
Changes in v2:
  - Fix spelling mor -> more
---
 drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 1ef4cb871452..fc587304b3c0 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -1204,7 +1204,7 @@ static int igb_alloc_q_vector(struct igb_adapter *adapter,
 	/* initialize pointer to rings */
 	ring = q_vector->ring;
 
-	/* intialize ITR */
+	/* initialize ITR */
 	if (rxr_count) {
 		/* rx or rx/tx vector */
 		if (!adapter->rx_itr_setting || adapter->rx_itr_setting > 3)
@@ -3906,7 +3906,7 @@ static void igb_remove(struct pci_dev *pdev)
  *
  *  This function initializes the vf specific data storage and then attempts to
  *  allocate the VFs.  The reason for ordering it this way is because it is much
- *  mor expensive time wise to disable SR-IOV than it is to allocate and free
+ *  more expensive time wise to disable SR-IOV than it is to allocate and free
  *  the memory for the VFs.
  **/
 static void igb_probe_vfs(struct igb_adapter *adapter)
-- 
2.43.0

Re: [Intel-wired-lan] [PATCH v2 1/1] [net-next] igb: Fix spelling in igb_main.c

[Paul Menzel]

Dear Johnny,


Thank you for your patch. I recommend to put the information, that the 
typos are only in comments, to the summary/title:

igb: Fix 2 typos in comments in igb_main.c

That way, skimming `git log --oneline` is more informative.

Am 23.10.24 um 05:21 schrieb Johnny Park:
> Simple patch that fix spelling mistakes in igb_main.c

fix*es*, but better use imperative mood:

Fix 2 spelling mistakes in comments `igb_main.c`.

> Signed-off-by: Johnny Park <pjohnny0508@gmail.com>
> ---
> Changes in v2:
>    - Fix spelling mor -> more
> ---
>   drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index 1ef4cb871452..fc587304b3c0 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -1204,7 +1204,7 @@ static int igb_alloc_q_vector(struct igb_adapter *adapter,
>   	/* initialize pointer to rings */
>   	ring = q_vector->ring;
>   
> -	/* intialize ITR */
> +	/* initialize ITR */
>   	if (rxr_count) {
>   		/* rx or rx/tx vector */
>   		if (!adapter->rx_itr_setting || adapter->rx_itr_setting > 3)
> @@ -3906,7 +3906,7 @@ static void igb_remove(struct pci_dev *pdev)
>    *
>    *  This function initializes the vf specific data storage and then attempts to
>    *  allocate the VFs.  The reason for ordering it this way is because it is much
> - *  mor expensive time wise to disable SR-IOV than it is to allocate and free
> + *  more expensive time wise to disable SR-IOV than it is to allocate and free
>    *  the memory for the VFs.
>    **/
>   static void igb_probe_vfs(struct igb_adapter *adapter)

Rest looks good.


Kind regards,

Paul

Re: [PATCH v2 1/1] [net-next] igb: Fix spelling in igb_main.c

[Simon Horman]

On Tue, Oct 22, 2024 at 09:21:28PM -0600, Johnny Park wrote:
> Simple patch that fix spelling mistakes in igb_main.c
> 
> Signed-off-by: Johnny Park <pjohnny0508@gmail.com>
> ---
> Changes in v2:
>   - Fix spelling mor -> more

Thanks for the update.
I checked and this addresses all false-positives flagged by codespell in
this file.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [Intel-wired-lan] [PATCH v2 1/1] [net-next] igb: Fix spelling in igb_main.c

[Johnny Park]

On Wed, Oct 23, 2024 at 10:04:45AM +0200, Paul Menzel wrote:
> Dear Johnny,
> 
> 
> Thank you for your patch. I recommend to put the information, that the typos
> are only in comments, to the summary/title:
> 
> igb: Fix 2 typos in comments in igb_main.c
> 
> That way, skimming `git log --oneline` is more informative.
> 
> Am 23.10.24 um 05:21 schrieb Johnny Park:
> > Simple patch that fix spelling mistakes in igb_main.c
> 
> fix*es*, but better use imperative mood:
> 
> Fix 2 spelling mistakes in comments `igb_main.c`.
> 
Hello Paul,

I appreciate your comments, I'll address those in the new patch shortly.

Thanks,

Johnny