public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Kreimer <algonell@gmail.com>
To: Dave Penkler <dpenkler@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Andrew Kreimer <algonell@gmail.com>, Greg KH <greg@kroah.com>
Subject: [PATCH v2] staging: gpib: Remove unnecessary TTY_LOG expansion
Date: Tue, 11 Feb 2025 11:30:13 +0200	[thread overview]
Message-ID: <20250211093051.15993-1-algonell@gmail.com> (raw)
In-Reply-To: <20250210121552.33455-1-algonell@gmail.com>

When drivers are successful, they should be quiet.

Remove the unnecessary TTY_LOG expansion.

Suggested-by: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Kreimer <algonell@gmail.com>
---
v2:
  - Change commit message/body.
  - Remove the TTY_LOG line as suggested.

v1:
  - Fix a typo in TTY_LOG message.

 drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
index 85322af62c23..b2c4d1d26f12 100644
--- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
+++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
@@ -542,7 +542,6 @@ static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confi
 		return -EIO;
 
 	SHOW_STATUS(board);
-	TTY_LOG("Module '%s' has been sucesfully configured\n", NAME);
 	return 0;
 }
 

Interdiff against v1:
  diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
  index 1c3e5dfcc9ec..b2c4d1d26f12 100644
  --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
  +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
  @@ -542,7 +542,6 @@ static int usb_gpib_attach(gpib_board_t *board, const gpib_board_config_t *confi
   		return -EIO;
   
   	SHOW_STATUS(board);
  -	TTY_LOG("Module '%s' has been successfully configured\n", NAME);
   	return 0;
   }
   

Range-diff against v1:
1:  779e59d74722 ! 1:  463e7000d1a7 staging: gpib: Fix typo in TTY_LOG message
    @@ Metadata
     Author: Andrew Kreimer <algonell@gmail.com>
     
      ## Commit message ##
    -    staging: gpib: Fix typo in TTY_LOG message
    +    staging: gpib: Remove unnecessary TTY_LOG expansion
     
    -    There is a typo in TTY_LOG message:
    -     - sucesfully -> successfully
    +    When drivers are successful, they should be quiet.
     
    -    Fix it via codespell.
    +    Remove the unnecessary TTY_LOG expansion.
     
    +    Suggested-by: Greg KH <greg@kroah.com>
         Signed-off-by: Andrew Kreimer <algonell@gmail.com>
     
      ## drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c ##
    @@ drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c: static int usb_gpib_attach(g
      
      	SHOW_STATUS(board);
     -	TTY_LOG("Module '%s' has been sucesfully configured\n", NAME);
    -+	TTY_LOG("Module '%s' has been successfully configured\n", NAME);
      	return 0;
      }
      
-- 
2.48.1.268.g9520f7d998


  parent reply	other threads:[~2025-02-11  9:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10 12:15 [PATCH] staging: gpib: Fix typo in TTY_LOG message Andrew Kreimer
2025-02-10 12:32 ` Greg KH
2025-02-11  9:30 ` Andrew Kreimer [this message]
2025-02-11 10:09   ` [PATCH v2] staging: gpib: Remove unnecessary TTY_LOG expansion Greg KH
2025-02-11 11:28     ` Andrew Kreimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250211093051.15993-1-algonell@gmail.com \
    --to=algonell@gmail.com \
    --cc=dpenkler@gmail.com \
    --cc=greg@kroah.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox