Re: [PATCH] usb: xhci: print xhci->xhc_state when queue_command failed

Greg KH
2025-07-25T04:44:00Z

On Fri, Jul 25, 2025 at 11:13:09AM +0800, Su Hui wrote:
> When encounters some errors like these:
> xhci_hcd 0000:4a:00.2: xHCI dying or halted, can't queue_command
> xhci_hcd 0000:4a:00.2: FIXME: allocate a command ring segment
> usb usb5-port6: couldn't allocate usb_device
>
> It's hard to know whether xhc_state is dying or halted. So it's better
> to print xhc_state's value which can help locate the resaon of the bug.
>
> Signed-off-by: Su Hui <suhui@nfschina.com>
> ---
> drivers/usb/host/xhci-ring.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index 94c9c9271658..a1a628e849c0 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -4372,7 +4372,8 @@ static int queue_command(struct xhci_hcd *xhci, struct xhci_command *cmd,
>
> if ((xhci->xhc_state & XHCI_STATE_DYING) ||
> (xhci->xhc_state & XHCI_STATE_HALTED)) {
> - xhci_dbg(xhci, "xHCI dying or halted, can't queue_command\n");
> + xhci_dbg(xhci, "xHCI dying or halted, can't queue_command. state: %u\n",
> + xhci->xhc_state);

Don't you want to see this value in hex?

thanks,

greg k-h