* [PATCH][next] ocfs2: Remove space before newline
@ 2025-07-29 11:41 Colin Ian King
2025-07-29 12:21 ` [PATCH] " Markus Elfring
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2025-07-29 11:41 UTC (permalink / raw)
To: Mark Fasheh, Joel Becker, Joseph Qi, ocfs2-devel
Cc: kernel-janitors, linux-kernel
There is an extraneous space before a newline in a mlog error message.
Remove it
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
fs/ocfs2/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
index a4f5a868bec1..4b3ea721395c 100644
--- a/fs/ocfs2/super.c
+++ b/fs/ocfs2/super.c
@@ -2108,7 +2108,7 @@ static int ocfs2_initialize_super(struct super_block *sb,
if (strlen(osb->osb_cluster_stack) != OCFS2_STACK_LABEL_LEN) {
mlog(ML_ERROR,
"couldn't mount because of an invalid "
- "cluster stack label (%s) \n",
+ "cluster stack label (%s)\n",
osb->osb_cluster_stack);
status = -EINVAL;
goto out_orphan_wipes;
--
2.50.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ocfs2: Remove space before newline
2025-07-29 11:41 [PATCH][next] ocfs2: Remove space before newline Colin Ian King
@ 2025-07-29 12:21 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2025-07-29 12:21 UTC (permalink / raw)
To: Colin Ian King, ocfs2-devel, Joel Becker, Joseph Qi, Mark Fasheh
Cc: kernel-janitors, LKML
…
> Remove it
Thus delete a redundant character.?
…
> +++ b/fs/ocfs2/super.c
> @@ -2108,7 +2108,7 @@ static int ocfs2_initialize_super(struct super_block *sb,
> if (strlen(osb->osb_cluster_stack) != OCFS2_STACK_LABEL_LEN) {
> mlog(ML_ERROR,
> "couldn't mount because of an invalid "
> - "cluster stack label (%s) \n",
> + "cluster stack label (%s)\n",
> osb->osb_cluster_stack);
…
You may recombine such string literals.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.16#n116
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-29 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-29 11:41 [PATCH][next] ocfs2: Remove space before newline Colin Ian King
2025-07-29 12:21 ` [PATCH] " Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox