From: Bjorn Helgaas <helgaas@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] PCI: cpqphp: move space in debug messages
Date: Wed, 6 Aug 2025 15:12:16 -0500 [thread overview]
Message-ID: <20250806201216.GA14834@bhelgaas> (raw)
In-Reply-To: <20250731101036.2167812-1-colin.i.king@gmail.com>
On Thu, Jul 31, 2025 at 11:10:36AM +0100, Colin Ian King wrote:
> The space in a handful of debug messages is in the wrong place, it
> is after a %d and before the \n, move it to be before the %d.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Applied (squashed into previous) to pci/hotplug for v6.18, thanks!
> ---
> drivers/pci/hotplug/cpqphp_pci.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/hotplug/cpqphp_pci.c b/drivers/pci/hotplug/cpqphp_pci.c
> index ef7534a3ca40..88929360fe77 100644
> --- a/drivers/pci/hotplug/cpqphp_pci.c
> +++ b/drivers/pci/hotplug/cpqphp_pci.c
> @@ -1302,7 +1302,7 @@ int cpqhp_find_available_resources(struct controller *ctrl, void __iomem *rom_st
>
> dbg("found io_node(base, length) = %x, %x\n",
> io_node->base, io_node->length);
> - dbg("populated slot =%d \n", populated_slot);
> + dbg("populated slot = %d\n", populated_slot);
> if (!populated_slot) {
> io_node->next = ctrl->io_head;
> ctrl->io_head = io_node;
> @@ -1325,7 +1325,7 @@ int cpqhp_find_available_resources(struct controller *ctrl, void __iomem *rom_st
>
> dbg("found mem_node(base, length) = %x, %x\n",
> mem_node->base, mem_node->length);
> - dbg("populated slot =%d \n", populated_slot);
> + dbg("populated slot = %d\n", populated_slot);
> if (!populated_slot) {
> mem_node->next = ctrl->mem_head;
> ctrl->mem_head = mem_node;
> @@ -1349,7 +1349,7 @@ int cpqhp_find_available_resources(struct controller *ctrl, void __iomem *rom_st
> p_mem_node->length = pre_mem_length << 16;
> dbg("found p_mem_node(base, length) = %x, %x\n",
> p_mem_node->base, p_mem_node->length);
> - dbg("populated slot =%d \n", populated_slot);
> + dbg("populated slot = %d\n", populated_slot);
>
> if (!populated_slot) {
> p_mem_node->next = ctrl->p_mem_head;
> @@ -1373,7 +1373,7 @@ int cpqhp_find_available_resources(struct controller *ctrl, void __iomem *rom_st
> bus_node->length = max_bus - secondary_bus + 1;
> dbg("found bus_node(base, length) = %x, %x\n",
> bus_node->base, bus_node->length);
> - dbg("populated slot =%d \n", populated_slot);
> + dbg("populated slot = %d\n", populated_slot);
> if (!populated_slot) {
> bus_node->next = ctrl->bus_head;
> ctrl->bus_head = bus_node;
> --
> 2.50.0
>
prev parent reply other threads:[~2025-08-06 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 10:10 [PATCH][next] PCI: cpqphp: move space in debug messages Colin Ian King
2025-08-06 20:12 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250806201216.GA14834@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=colin.i.king@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox