* [PATCH net] ipv4: Fix NULL vs error pointer check in inet_blackhole_dev_init()
@ 2025-09-02 6:36 Dan Carpenter
2025-09-02 12:14 ` Simon Horman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2025-09-02 6:36 UTC (permalink / raw)
To: Xin Long
Cc: David S. Miller, David Ahern, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman, netdev, linux-kernel, kernel-janitors
The inetdev_init() function never returns NULL. Check for error
pointers instead.
Fixes: 22600596b675 ("ipv4: give an IPv4 dev to blackhole_netdev")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
net/ipv4/devinet.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index c47d3828d4f6..942a887bf089 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -340,14 +340,13 @@ static void inetdev_destroy(struct in_device *in_dev)
static int __init inet_blackhole_dev_init(void)
{
- int err = 0;
+ struct in_device *in_dev;
rtnl_lock();
- if (!inetdev_init(blackhole_netdev))
- err = -ENOMEM;
+ in_dev = inetdev_init(blackhole_netdev);
rtnl_unlock();
- return err;
+ return PTR_ERR_OR_ZERO(in_dev);
}
late_initcall(inet_blackhole_dev_init);
--
2.47.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] ipv4: Fix NULL vs error pointer check in inet_blackhole_dev_init()
2025-09-02 6:36 [PATCH net] ipv4: Fix NULL vs error pointer check in inet_blackhole_dev_init() Dan Carpenter
@ 2025-09-02 12:14 ` Simon Horman
2025-09-02 12:18 ` Eric Dumazet
2025-09-04 0:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2025-09-02 12:14 UTC (permalink / raw)
To: Dan Carpenter
Cc: Xin Long, David S. Miller, David Ahern, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, linux-kernel,
kernel-janitors
On Tue, Sep 02, 2025 at 09:36:08AM +0300, Dan Carpenter wrote:
> The inetdev_init() function never returns NULL. Check for error
> pointers instead.
>
> Fixes: 22600596b675 ("ipv4: give an IPv4 dev to blackhole_netdev")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] ipv4: Fix NULL vs error pointer check in inet_blackhole_dev_init()
2025-09-02 6:36 [PATCH net] ipv4: Fix NULL vs error pointer check in inet_blackhole_dev_init() Dan Carpenter
2025-09-02 12:14 ` Simon Horman
@ 2025-09-02 12:18 ` Eric Dumazet
2025-09-04 0:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Eric Dumazet @ 2025-09-02 12:18 UTC (permalink / raw)
To: Dan Carpenter
Cc: Xin Long, David S. Miller, David Ahern, Jakub Kicinski,
Paolo Abeni, Simon Horman, netdev, linux-kernel, kernel-janitors
On Mon, Sep 1, 2025 at 11:36 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> The inetdev_init() function never returns NULL. Check for error
> pointers instead.
>
> Fixes: 22600596b675 ("ipv4: give an IPv4 dev to blackhole_netdev")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] ipv4: Fix NULL vs error pointer check in inet_blackhole_dev_init()
2025-09-02 6:36 [PATCH net] ipv4: Fix NULL vs error pointer check in inet_blackhole_dev_init() Dan Carpenter
2025-09-02 12:14 ` Simon Horman
2025-09-02 12:18 ` Eric Dumazet
@ 2025-09-04 0:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-09-04 0:10 UTC (permalink / raw)
To: Dan Carpenter
Cc: lucien.xin, davem, dsahern, edumazet, kuba, pabeni, horms, netdev,
linux-kernel, kernel-janitors
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 2 Sep 2025 09:36:08 +0300 you wrote:
> The inetdev_init() function never returns NULL. Check for error
> pointers instead.
>
> Fixes: 22600596b675 ("ipv4: give an IPv4 dev to blackhole_netdev")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> net/ipv4/devinet.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Here is the summary with links:
- [net] ipv4: Fix NULL vs error pointer check in inet_blackhole_dev_init()
https://git.kernel.org/netdev/net/c/a51160f8da85
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-04 0:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-02 6:36 [PATCH net] ipv4: Fix NULL vs error pointer check in inet_blackhole_dev_init() Dan Carpenter
2025-09-02 12:14 ` Simon Horman
2025-09-02 12:18 ` Eric Dumazet
2025-09-04 0:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox