* [PATCH next] EDAC/versalnet: Fix off by one in handle_error()
@ 2025-09-27 12:26 Dan Carpenter
2025-10-08 13:56 ` Yazen Ghannam
2025-10-13 17:04 ` Borislav Petkov
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-09-27 12:26 UTC (permalink / raw)
To: Shubhrajyoti Datta
Cc: Borislav Petkov, Tony Luck, linux-edac, linux-kernel,
kernel-janitors
The priv->mci[] array has NUM_CONTROLLERS so this > comparison needs to
be >= to prevent an out of bounds access.
Fixes: d5fe2fec6c40 ("EDAC: Add a driver for the AMD Versal NET DDR controller")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/edac/versalnet_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c
index 7c5db8bf0595..1ded4c3f0213 100644
--- a/drivers/edac/versalnet_edac.c
+++ b/drivers/edac/versalnet_edac.c
@@ -433,7 +433,7 @@ static void handle_error(struct mc_priv *priv, struct ecc_status *stat,
phys_addr_t pfn;
int err;
- if (WARN_ON_ONCE(ctl_num > NUM_CONTROLLERS))
+ if (WARN_ON_ONCE(ctl_num >= NUM_CONTROLLERS))
return;
mci = priv->mci[ctl_num];
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH next] EDAC/versalnet: Fix off by one in handle_error()
2025-09-27 12:26 [PATCH next] EDAC/versalnet: Fix off by one in handle_error() Dan Carpenter
@ 2025-10-08 13:56 ` Yazen Ghannam
2025-10-13 17:04 ` Borislav Petkov
1 sibling, 0 replies; 3+ messages in thread
From: Yazen Ghannam @ 2025-10-08 13:56 UTC (permalink / raw)
To: Dan Carpenter
Cc: Shubhrajyoti Datta, Borislav Petkov, Tony Luck, linux-edac,
linux-kernel, kernel-janitors
On Sat, Sep 27, 2025 at 03:26:34PM +0300, Dan Carpenter wrote:
> The priv->mci[] array has NUM_CONTROLLERS so this > comparison needs to
> be >= to prevent an out of bounds access.
>
> Fixes: d5fe2fec6c40 ("EDAC: Add a driver for the AMD Versal NET DDR controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
Thanks,
Yazen
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH next] EDAC/versalnet: Fix off by one in handle_error()
2025-09-27 12:26 [PATCH next] EDAC/versalnet: Fix off by one in handle_error() Dan Carpenter
2025-10-08 13:56 ` Yazen Ghannam
@ 2025-10-13 17:04 ` Borislav Petkov
1 sibling, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2025-10-13 17:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Shubhrajyoti Datta, Tony Luck, linux-edac, linux-kernel,
kernel-janitors
On Sat, Sep 27, 2025 at 03:26:34PM +0300, Dan Carpenter wrote:
> The priv->mci[] array has NUM_CONTROLLERS so this > comparison needs to
> be >= to prevent an out of bounds access.
>
> Fixes: d5fe2fec6c40 ("EDAC: Add a driver for the AMD Versal NET DDR controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/edac/versalnet_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c
> index 7c5db8bf0595..1ded4c3f0213 100644
> --- a/drivers/edac/versalnet_edac.c
> +++ b/drivers/edac/versalnet_edac.c
> @@ -433,7 +433,7 @@ static void handle_error(struct mc_priv *priv, struct ecc_status *stat,
> phys_addr_t pfn;
> int err;
>
> - if (WARN_ON_ONCE(ctl_num > NUM_CONTROLLERS))
> + if (WARN_ON_ONCE(ctl_num >= NUM_CONTROLLERS))
> return;
>
> mci = priv->mci[ctl_num];
> --
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-13 17:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-27 12:26 [PATCH next] EDAC/versalnet: Fix off by one in handle_error() Dan Carpenter
2025-10-08 13:56 ` Yazen Ghannam
2025-10-13 17:04 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox