From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28667333458 for ; Fri, 31 Oct 2025 09:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761904297; cv=none; b=Ef/F0vUHp8WnivDf9zoiNP9VWIjFKrpZNmvkU9pfiicDXvdxrcsWZOvjxsGula3V+yGGoUWZ3N1zf0U4nEqOXPIvV/Gi+sS51zO8CvvLSejPe/u8aIF6eaoi/ykKvoUKeoucqecV7e3PTM8bklxHZOxbQHpzBZ0jPKgE1ajT5XU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761904297; c=relaxed/simple; bh=RwoS/PDm0zxnUlW4Huu6pywDv/HskMxqzUb9B5plkDs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sthrWx8Qm6F/smDK7hkQ6Y1iAzT9d8HnyylVWWQzApQqA+hw39c0IDaKSpP9JIc05O0lVW6HEwTirqEAdXbWXAeCRTyR1JhsIe9ts2LIME4I6Hc9wW+Xg6edG2dyvz/AKDdQHNSutU2s+V2ZXdI5n3Q4zntcAI3oIXiu75cE3W8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gxT4RJ95; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gxT4RJ95" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-47719ad0c7dso18421215e9.0 for ; Fri, 31 Oct 2025 02:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761904294; x=1762509094; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=3IQtVhF5z2Qs400V3EordEf1XdwEv4+Wc34rjUmUuvY=; b=gxT4RJ95rehUKo7kmquvEjbm5CIUe2zg10bCdu0yBv80WzaE1vWnmnVANFa/gwPgDl P3IaT/6VVLGZ+fc05r8VYMJBomKGRow920LnwPRZ9lk7dKeSclCxBLwiju34I/7tFlBj 3+Z712Fhs33j7zMLvmWjYiXwAK2F7mTCxt6/trz4Bqh64ALZ4B61ZjBo0uuwt3foE5AU t0UiJ81Om6aLoswj0i400sE0IgLYf47gdZWTLyCfxlGvJmsAGZYd3/kyxzdFy1kRkHp5 +TpFplkswQcJO5dMRDThmXNlfRI0EHIbR/5gMC0tD1HcGKDEuSfdikaw21qSEgs5VXdm eQCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761904294; x=1762509094; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3IQtVhF5z2Qs400V3EordEf1XdwEv4+Wc34rjUmUuvY=; b=t/b8nvcKnR2OHSmlWTLk4mW00aG4viVSrH4JQdBRziqaSHvf+RA0Osb6TfSRY5nSAJ Xv/vdo0w990NNh7qfzpyZMNGSls6hF3wKVawke7tSBkyuuEP4rKUaCjPEJgIolXxlDIh VsgAMj1r7kjwcc5TWrb2YZR9Zb6eAmDxP6U1Z7V9sjX+x2WQ+67tebr03hRzRukPXI0H SXOCBExjkgEQHuWnpQ+PGzCLjiDQO8ngCh96oPvkv+XY5F5CB0b13dDayt+HM74V9GrL 0s7tp+Sg7EETQfjgdSJyhK83aQQFDPizKDHyR/DEsO6wi84XeewD+ZLqTMazHpVepsTG EG8A== X-Forwarded-Encrypted: i=1; AJvYcCViTkSnPkcIvFg3NR7IhUUab1DDpyaprv97sof67oeSuJ50rsHrrgF6FZMz8OW3uldHB1p762eCrPD5bFm2wRI=@vger.kernel.org X-Gm-Message-State: AOJu0YwY9WRCGUklJJt7m/eGLOmt+eUlklrvGfoOn5siBKP/hTfa+8tu TS2D28jOV/LJrbBAokig5fRciuyaP25edspnfGuCPMzrE8NmoFfldDhx X-Gm-Gg: ASbGncuSwPm3R3+D1DqO/P67ohSv6oGA6i4gNopsyD7gpRGWFgPHlvFn3dh6Ly4CrBM u6+8N557t8br6O0rDsY7UA67ZNjIQNSighgMpuxrAcU0Av1/m05bnxAPsblFTXFStk6jJ6HhovP o+eGnFr58Cq5K5/6TSAd9523knzO3F1SuXY3u6vZb4UiAD+lF8rci1UXZpYznKnmONUbSIWoxvR Sf4oGl47cA/p2UDz8ZtfoAXsUOQxTbk54OGuaK+dTzzwYKz+w/1CviQv4ZdJVRiIZKlTmz5AFoH He2YWJyR16/UnfXhwD8rP8JCi8j5HMnov3jEnZbbDcOylyKjUU8E9tP7L11KpX0gmyCrcZqVGsE puukcR0+O2RZVDKW+QSXpezKJ/lG2KqswMUSNzVmCopWWRpR4lkc4cL7POhMg14vSG+Oc+KbKez jvOdgm/IUcqPeLIc05WAONMFORr9mU7QbLv0I/wD2uJoKr0g69+J+l X-Google-Smtp-Source: AGHT+IHhOwaM87UnJaQRrN7fhHF0k/Vk8dAJKE4DsDjg6unQFW9Cs7BqIsOLGGMUISX91/3zXJdi9g== X-Received: by 2002:a05:600c:630e:b0:471:11a3:a6a9 with SMTP id 5b1f17b1804b1-477308acfe4mr25198435e9.37.1761904294421; Fri, 31 Oct 2025 02:51:34 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477389b3acasm10684535e9.6.2025.10.31.02.51.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 02:51:34 -0700 (PDT) Date: Fri, 31 Oct 2025 09:51:32 +0000 From: David Laight To: Markus Elfring Cc: Geert Uytterhoeven , sparclinux@vger.kernel.org, Alexandre Belloni , Andreas Larsson , Christoph Lameter , "David S. Miller" , Finn Thain , Tejun Heo , LKML , kernel-janitors@vger.kernel.org, Miaoqian Lin Subject: Re: [PATCH] sparc: time: Use pointer from memcpy() call for assignment in setup_sparc64_timer() Message-ID: <20251031095132.3db72d29@pumpkin> In-Reply-To: <33199802-d83d-48e8-9032-f1c4c61cfee7@web.de> References: <2fa899eb-60b6-4637-9035-aeff78e261fa@web.de> <33199802-d83d-48e8-9032-f1c4c61cfee7@web.de> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 31 Oct 2025 09:46:25 +0100 Markus Elfring wrote: > =E2=80=A6>> +++ b/arch/sparc/kernel/time_64.c > >> @@ -760,9 +760,7 @@ void setup_sparc64_timer(void) > >> : /* no outputs */ > >> : "r" (pstate)); > >> > >> - sevt =3D this_cpu_ptr(&sparc64_events); > >> - > >> - memcpy(sevt, &sparc64_clockevent, sizeof(*sevt)); > >> + sevt =3D memcpy(this_cpu_ptr(&sparc64_events), &sparc64_clocke= vent, sizeof(*sevt)); =20 > >=20 > > IMHO this makes the code harder to read: > > - Only 0.15% of the memcpy() calls in the kernel use the > > memcpy() chaining feature, =20 >=20 > I obviously propose to refactor this implementation detail. Reduce it to 0% and the kernel memcpy() can be made 'void'. :-) That will simplify the architecture specific implementations. The same can be done for strcpy() and strcat() (etc). Where the 'useful' return value would be the address of the '\0'. David