From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 344D43C13FD for ; Wed, 22 Apr 2026 10:58:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776855499; cv=none; b=a+6+Iw3LyF/vnQXTyYM6e9PF5nYRolj48C8YkTUPLqmn/1TCZQL281CaXxHDeL+88yzP3N/aO62C1Eyo/Vwr1L8YrtJU5r0XDU30VFXC23jA+hbqIpBuQAWe8mzKHOhwIVue8+7EWgdICp4as5q2n3JHaYQUTx0siRElGIBqaE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776855499; c=relaxed/simple; bh=087e/nvJmgEeLsXW0RHyWGzu7RXBNSYdUUjS8aydZE4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:MIME-Version: Content-Type:References; b=pO5b+PO3IuBf0VOu6AqnggUPOkHb3z5tLW7DdwXM8jWbTtyTdJigIIXh1XPDZGpviwgugk53Yy74p7ZCnOSkmecummLpT5Mpgk2pA8q9DOhK78zsHsSvpH/NmQPvvNu5IcJYqUSDNCCPlbiKm2GkjrDsFsfC9AkXui0nhJh7liU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=O78c/4K0; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="O78c/4K0" Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20260422105814euoutp012ca4f4c7d567222a4de774ca5bb969fe~oqKhoRCk51362513625euoutp01f for ; Wed, 22 Apr 2026 10:58:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20260422105814euoutp012ca4f4c7d567222a4de774ca5bb969fe~oqKhoRCk51362513625euoutp01f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1776855494; bh=HqZ/MfNxixsoC5HUHKPFpN1nTHkNJ5klIDKPGmogXBs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O78c/4K0wAM0YGFZ8WN3N64GlFLsKgB+jiRv60SEoZNAtbVhzpEKeYLSMQ3/7khUI 7FdazqVt7/3sz75rbUY+Fp10sbMgXkCVo6VQO9Z/HgAclQmWNllebCaL2MoUfZ7r90 6LR38jWBGRGtiD0X6Pdxi7+TFxiEdSSqqVavZBJU= Received: from eusmtip1.samsung.com (unknown [203.254.199.221]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20260422105813eucas1p1a59a07ab8c1ac0c4b7eba37d509f69b8~oqKhYw4N90671706717eucas1p1Y; Wed, 22 Apr 2026 10:58:13 +0000 (GMT) Received: from AMDC4843.eu.corp.samsungelectronics.net (unknown [106.120.77.61]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20260422105813eusmtip15775a2bab96a887094e270ad7d48787e~oqKhA-sow1020810208eusmtip1X; Wed, 22 Apr 2026 10:58:13 +0000 (GMT) From: Jakub Raczynski To: error27@gmail.com Cc: netdev@vger.kernel.org, kuba@kernel.org, przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com, kernel-janitors@vger.kernel.org, Jakub Raczynski Subject: [PATCH v2] net/intel: Replace manual array size calculation with ARRAY_SIZE Date: Wed, 22 Apr 2026 12:57:12 +0200 Message-Id: <20260422105710.268003-1-j.raczynski@samsung.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CMS-MailID: 20260422105813eucas1p1a59a07ab8c1ac0c4b7eba37d509f69b8 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20260422105813eucas1p1a59a07ab8c1ac0c4b7eba37d509f69b8 X-EPHeader: CA X-CMS-RootMailID: 20260422105813eucas1p1a59a07ab8c1ac0c4b7eba37d509f69b8 References: There are still places in the code where manual calculation of array size exist, but it is good to enforce usage of single macro through the whole code as it makes code bit more readable. While at it, beautify condition surrounding it by reversing check and remove unnecessary casting. Signed-off-by: Jakub Raczynski --- drivers/net/ethernet/intel/i40e/i40e_adminq.h | 2 +- drivers/net/ethernet/intel/iavf/iavf_adminq.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.h b/drivers/net/ethernet/intel/i40e/i40e_adminq.h index 1be97a3a86ce..dcf3baec7b73 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_adminq.h +++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.h @@ -109,7 +109,7 @@ static inline int i40e_aq_rc_to_posix(int aq_ret, int aq_rc) -EFBIG, /* I40E_AQ_RC_EFBIG */ }; - if (!((u32)aq_rc < (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0])))) + if (aq_rc >= ARRAY_SIZE(aq_to_posix)) return -ERANGE; return aq_to_posix[aq_rc]; diff --git a/drivers/net/ethernet/intel/iavf/iavf_adminq.h b/drivers/net/ethernet/intel/iavf/iavf_adminq.h index bbf5c4b3a2ae..dd2f61172157 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_adminq.h +++ b/drivers/net/ethernet/intel/iavf/iavf_adminq.h @@ -113,7 +113,7 @@ static inline int iavf_aq_rc_to_posix(int aq_ret, int aq_rc) if (aq_ret == IAVF_ERR_ADMIN_QUEUE_TIMEOUT) return -EAGAIN; - if (!((u32)aq_rc < (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0])))) + if (aq_rc >= ARRAY_SIZE(aq_to_posix)) return -ERANGE; return aq_to_posix[aq_rc]; -- 2.34.1