From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AF653CF02A for ; Wed, 22 Apr 2026 13:03:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776863027; cv=none; b=NRXI10B0Rc0UBMpU8rx9Pn/AeoN5W+TX3vJNYaVyoJyI8gSN0y5avWXqkZpwpWoPNPL0z0C1CQTOiAokl6Y8qwF2iUhyVzuDVo16qxG0BzRCSLvoDigdyRvUizvf/ru990gbCp8ckF54PcLTVU95t3qwK3csPo2bXX09MpIBiug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776863027; c=relaxed/simple; bh=NVp5rKRYc5QSU6T0BrJ5kTBob2N0jngaeZMRgSzkKTI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F1TKNVQdpxLKHkmEiiWEJ/xBDsNBznlcsxSJ5IyqID5UVOHI7WgDPfwel9/5Oj0CCm2v6dL9sDXdtCpGkMwb+D4E2RThjZAqo4DC/6HmtTjl1TUrwrmywX9sieIOfcX4r1WsVVoOc04nrez22Wp4shB5xCJFO97JFIshjyxttn8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g022hXn7; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g022hXn7" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b9d9971d059so798689066b.2 for ; Wed, 22 Apr 2026 06:03:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776863024; x=1777467824; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6DxlUcAzvEB7U+i5O0kj+4iBEHjE40skBjf9E+7IN5g=; b=g022hXn7mJYo98CrQVe0weyAw1cvWrg04DNbWu2Kjw5JpG5u/i9GIMxP0YTb0abKum xSZzILS83d8iA0tunQR++NxgmGUEKVlc5pau6zhf2euIIM9DELwsjiDQcB4f4+2BMAaL xDnQPf9fAZdOwyuq/onFNqGDNJ/erwjUE4Aflia+1ZpdEieFVgFbdDEUoEL+ujxpJ7cA wcd7AJwZTpY0Mv9/Stz4eSnS1FUXFXLtzqCKdWIorSgl2IPTRT/x7JcGtqZ+Ceez7yCM GXSvKV5IAJUI3AwAOa3bMKaqcAAbHXiipPQo++uel7dpwJ4gow4uvwJO4Ph73P4kw8ek bKdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776863024; x=1777467824; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6DxlUcAzvEB7U+i5O0kj+4iBEHjE40skBjf9E+7IN5g=; b=D5MatiT4/gBN6y058qljhq9lZDgbumW2z1AeRLpidQP1Lq9jksEViEjRzELHQN59mF W9NIerdpQHT3Fo738ZdzSmMQbhuRy79aoHvlDZ8KrlJRG55oxgye5v6dddJuZIzaJByb MZ9knLYvDVP2czFKb7lxHcn9ZHGt7r4lF6cy9tGDX7fl1qztt0B5niBLh6uWBbakBH2w pO1LOOAE7aqRuuSH+HrRgDY5UJbUFE304XG8PmWhyNXE3Jcnc49K9lXivtyflNFpdSxl Zc0ei8d+7qppW3teEYhA5zfRBQk25hXpCNI4tyWNg42EMe1zuaXFHIvJnhZMjp5kiuAS V5sw== X-Forwarded-Encrypted: i=1; AFNElJ8+ZRTM/Mh0y0TffpT+ZH5eppkjcd3kr/9TijRaE7IcwnqNFpOIsA4WR4QSqWGXUQiymLVOpffXxLHJOEbn2js=@vger.kernel.org X-Gm-Message-State: AOJu0YzCiRAoT3fH04/Kr7cJ8qYqDqptcfOwcvRjfuQ8JC3GtjhSTGW+ Br2TjRwoxbsnVz2ca9k+xVyPIfAAw9WW07dk3CO1tTBeQt34RY2BdhSd X-Gm-Gg: AeBDiesL1FrICxKcDpbkpQPLSs1N9SHvAFmhZHluzne/RlsJaldnDOCSh0IHvAX2clo hsOOQ33xJ5LSWSAyXAWiIqTtvWXdIOAS6nNMz2vsXXYWClrJhdQ6iYhyJfzlRqf36xKJAVBpP8d nChf06LATKc6NM/vUoZqtFHETTweN6R4NvxYj5cD5Mjz8T9TwzFN/I7Fybwf7VTxICPmdmjPUyh QDhmFatGAxOVTy3RdlkB2L492++riDNfdf06xSkt2tIfGRJnZX2Fji+u4mZIQCn4DElSt11ypeb IyX1qzUnJr9UCkyIY+69gIyxxIS1BxP5+/JG1/HImSrYXv7r3/J87v5SNgmJ8ORra2na2TD6N4y d6CBfq65QpR7ucOt1CKCam6MIc+2Sgr/oslm6I7ZWwiCLA9S0mbKkjnojd3lXKYvO/rE6V5ePHG 18kSqQGiSA2ZRrTTm/pa2EYaLGxSiBDDTrpVUC4xYfK1m/Ty4+hJsbA/728Z44DY8E7dHYiIxb4 3I3ZaDK8SzDnhj4gqSQzURIWG8CPjbMu/7WRA== X-Received: by 2002:a17:907:847:b0:b9c:a70c:d30b with SMTP id a640c23a62f3a-ba418e85407mr1112598566b.19.1776863023946; Wed, 22 Apr 2026 06:03:43 -0700 (PDT) Received: from arch-piotr.tailb7ebba.ts.net (226.55.classcom.pl. [195.150.55.226]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba4520c93c7sm531722966b.27.2026.04.22.06.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 06:03:42 -0700 (PDT) From: Piotr Zarycki To: vkuznets@redhat.com Cc: kvm@vger.kernel.org, seanjc@google.com, pbonzini@redhat.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Piotr Zarycki Subject: [PATCH v2] KVM: selftests: hyperv_tlb_flush: replace NOP loop with udelay() Date: Wed, 22 Apr 2026 15:03:07 +0200 Message-ID: <20260422130307.1171808-1-piotr.zarycki@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <87v7djgoji.fsf@redhat.com> References: <87v7djgoji.fsf@redhat.com> Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the open-coded NOP loop with udelay() which was added to KVM selftests in commit 6b878cbb87bf ("KVM: selftests: Add guest udelay() utility for x86"). The NOP loop is CPU speed dependent while udelay() provides a deterministic delay regardless of host CPU frequency. Signed-off-by: Piotr Zarycki --- .../testing/selftests/kvm/x86/hyperv_tlb_flush.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/tools/testing/selftests/kvm/x86/hyperv_tlb_flush.c b/tools/testing/selftests/kvm/x86/hyperv_tlb_flush.c index c542cc4762b1..4b7f089542c1 100644 --- a/tools/testing/selftests/kvm/x86/hyperv_tlb_flush.c +++ b/tools/testing/selftests/kvm/x86/hyperv_tlb_flush.c @@ -141,17 +141,6 @@ static void swap_two_test_pages(vm_paddr_t pte_gva1, vm_paddr_t pte_gva2) *(uint64_t *)pte_gva2 = tmp; } -/* - * TODO: replace the silly NOP loop with a proper udelay() implementation. - */ -static inline void do_delay(void) -{ - int i; - - for (i = 0; i < 1000000; i++) - asm volatile("nop"); -} - /* * Prepare to test: 'disable' workers by setting the expectation to '0', * clear hypercall input page and then swap two test pages. @@ -169,7 +158,7 @@ static inline void prepare_to_test(struct test_data *data) wmb(); /* Make sure workers have enough time to notice */ - do_delay(); + udelay(100); /* Swap test page mappings */ swap_two_test_pages(data->test_pages_pte[0], data->test_pages_pte[1]); @@ -189,7 +178,7 @@ static inline void post_test(struct test_data *data, u64 exp1, u64 exp2) set_expected_val((void *)data->test_pages, exp2, WORKER_VCPU_ID_2); /* Make sure workers have enough time to test */ - do_delay(); + udelay(100); } #define TESTVAL1 0x0101010101010101 -- 2.53.0