From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Date: Tue, 15 Jan 2019 18:43:00 +0000 Subject: Re: [PATCH v3 -next] ACPI: APEI: EINJ: Use DEFINE_DEBUGFS_ATTRIBUTE for debugfs files Message-Id: <2143946.D49o9LbKFd@aspire.rjw.lan> List-Id: References: <1546435088-45448-1-git-send-email-yuehaibing@huawei.com> In-Reply-To: <1546435088-45448-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org On Monday, January 14, 2019 11:51:51 AM CET Borislav Petkov wrote: > On Wed, Jan 02, 2019 at 01:18:08PM +0000, YueHaibing wrote: > > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > > for debugfs files to make debugfs_simple_attr.cocci warnings go away. > > > > Semantic patch information: > > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > > imposes some significant overhead as compared to > > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > > > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > > > Signed-off-by: YueHaibing > > --- > > v3: add semantic patch information > > v2: fix patch title and log > > --- > > drivers/acpi/apei/einj.c | 17 +++++++++-------- > > 1 file changed, 9 insertions(+), 8 deletions(-) > > Acked-by: Borislav Petkov Patch applied, thanks!