From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F88C433B4 for ; Sun, 11 Apr 2021 18:24:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CBBD6109F for ; Sun, 11 Apr 2021 18:24:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236135AbhDKSZB convert rfc822-to-8bit (ORCPT ); Sun, 11 Apr 2021 14:25:01 -0400 Received: from mailoutvs31.siol.net ([185.57.226.222]:55289 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235229AbhDKSZA (ORCPT ); Sun, 11 Apr 2021 14:25:00 -0400 X-Greylist: delayed 488 seconds by postgrey-1.27 at vger.kernel.org; Sun, 11 Apr 2021 14:24:53 EDT Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id E0BF9525531; Sun, 11 Apr 2021 20:18:42 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta09.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta09.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id eZShPbwdXxkD; Sun, 11 Apr 2021 20:18:42 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id A100952552D; Sun, 11 Apr 2021 20:18:42 +0200 (CEST) Received: from kista.localnet (cpe-86-58-17-133.cable.triera.net [86.58.17.133]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id F1B3B525539; Sun, 11 Apr 2021 20:18:41 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: lujialin4@huawei.com, Mauro Carvalho Chehab , Maxime Ripard , Chen-Yu Tsai , Philipp Zabel , Lu Jialin Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] media: sun8i: Fix PM reference leak in deinterlace_start_streaming() Date: Sun, 11 Apr 2021 20:18:41 +0200 Message-ID: <2184866.DZomrXFPLt@kista> In-Reply-To: <20210408133630.56299-1-lujialin4@huawei.com> References: <20210408133630.56299-1-lujialin4@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org Dne četrtek, 08. april 2021 ob 15:36:30 CEST je Lu Jialin napisal(a): > > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. > > Reported-by: Hulk Robot > Signed-off-by: Lu Jialin Acked-by: Jernej Skrabec Best regards, Jernej