From: Dave Airlie <airlied@gmail.com>
To: Darren Jenkins <darrenrjenkins@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel mailing list <dri-devel@lists.sourceforge.net>,
Kernel Janitors <kernel-janitors@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/radeon/radeon_cp.c: check for invalid radeon family
Date: Thu, 07 Jan 2010 03:48:49 +0000 [thread overview]
Message-ID: <21d7e9971001061948m466e0abdwb03ceef2cb947687@mail.gmail.com> (raw)
In-Reply-To: <1262136235.8733.33.camel@ICE-BOX>
On Wed, Dec 30, 2009 at 11:23 AM, Darren Jenkins
<darrenrjenkins@gmail.com> wrote:
> If there is an invalid radeon family the fw_name is NULL and causes an
> NULL pointer dereference.
> This just adds a check for something unexpected.
>
Same as for last one, unless a developer explicity writes code wrong,
this cannot
happen, and I'd prefer a developer would see an oops.
Dave.
prev parent reply other threads:[~2010-01-07 3:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 1:23 [PATCH] drm/radeon/radeon_cp.c: check for invalid radeon family Darren Jenkins
2010-01-07 3:48 ` Dave Airlie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21d7e9971001061948m466e0abdwb03ceef2cb947687@mail.gmail.com \
--to=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=darrenrjenkins@gmail.com \
--cc=dri-devel@lists.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox