From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Mon, 07 Aug 2017 15:21:26 +0000 Subject: Re: [PATCH 3/4] thermal: exynos: constify thermal_zone_of_device_ops structures Message-Id: <2246245.2R0fntX3Po@amdc3058> List-Id: References: <1501965437-30730-1-git-send-email-Julia.Lawall@lip6.fr> <1501965437-30730-4-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1501965437-30730-4-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Saturday, August 05, 2017 10:37:16 PM Julia Lawall wrote: > The thermal_zone_of_device_ops structure is only passed as the fourth > argument to thermal_zone_of_sensor_register, which is declared as const. > Thus the thermal_zone_of_device_ops structure itself can be const. > > Done with the help of Coccinelle. > > // > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct thermal_zone_of_device_ops i@p = { ... }; > > @ok1@ > identifier r.i; > expression e1,e2,e3; > position p; > @@ > thermal_zone_of_sensor_register(e1,e2,e3,&i@p) > > @bad@ > position p != {r.p,ok1.p}; > identifier r.i; > struct thermal_zone_of_device_ops e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct thermal_zone_of_device_ops i = { ... }; > // > > Signed-off-by: Julia Lawall Acked-by: Bartlomiej Zolnierkiewicz Eduardo/Zhang, Please queue this patch for upstream, thanks! Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics