Re: [PATCH] net/bonding: adjust codingstyle for bond_3ad files.

Rafael Aquini
2011-05-06T14:56:04Z

Howdy Nicolas,

On Fri, May 06, 2011 at 03:01:14PM +0200, Nicolas Kaiser wrote:
> The indentation of parentheses looks correct to me in the original version.
> However, this expression can also be simplified like
>
> if (active && active->lag_ports &&
> active->lag_ports->is_enabled &&
> - (__agg_has_partner(active) ||
> - (!__agg_has_partner(active) && !__agg_has_partner(best)))) {
> + (__agg_has_partner(active) || !__agg_has_partner(best))) {
> if (!(!active->actor_oper_aggregator_key &&
> best->actor_oper_aggregator_key)) {
> best = NULL;
>
> Last October I submitted such a patch which also simplified the
> double negation in the subsequent expression.

Thanks for the feedback!

Send me this patch of yours, I'll try to merge our paths and resubmit adding
you as a signer as well

Cheers!
--
Rafael Aquini <aquini@linux.com>