Re: [PATCH] net/bonding: adjust codingstyle for bond_3ad files

David Miller
2011-05-09T00:12:04Z

From: Håkon Løvdal <hlovdal@gmail.com>
Date: Mon, 9 May 2011 02:08:41 +0200

> void bond_3ad_state_machine_handler(struct work_struct *work)
> {
> struct bonding *bond = container_of(work, struct bonding,
> ad_work.work);
> struct port *port;
> struct aggregator *aggregator;
>
> read_lock(&bond->lock);
>
> if (! bond->kill_timers) {
>
> //check if there are any slaves
> if (bond->slave_cnt != 0) {
> ...
> }
> queue_delayed_work(bond->wq, &bond->ad_work, ad_delta_in_ticks);
> }
> read_unlock(&bond->lock);
> }
>
>
> And this was what I trying to reccommend against (and which the
> stackoverflow question is about).

I really don't see anything wrong with either approach.

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html