Re: [PATCH] afs: remove redundant assignment to variable ret

David Howells
2019-05-12T06:55:26Z

Colin King <colin.king@canonical.com> wrote:

> The variable ret is being assigned a value however this is never
> read and later it is being reassigned to a new value. The assignment
> is redundant and hence can be removed.

No.

> if (ret = 0) {
> ret = acl->size;
> if (size > 0) {
> - ret = -ERANGE;
> if (acl->size > size)
> return -ERANGE;
> memcpy(buffer, acl->data, acl->size);

This is the wrong solution. acl and key need releasing, so the return should
be a goto.

David