From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Date: Sun, 08 Feb 2015 23:28:35 +0000 Subject: Re: [PATCH 1/1] drivers/base: Remove unnecessary OOM message Message-Id: <2675935.6VkJO9HMpc@vostro.rjw.lan> List-Id: References: <20150206153912.GA8486@sloth> <20150206211708.GA25967@amd> <20150207102436.GB5206@mwanda> In-Reply-To: <20150207102436.GB5206@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Quentin Lambert Cc: Pavel Machek , Joe Perches , Ming Lei , Greg Kroah-Hartman , Len Brown , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org On Saturday, February 07, 2015 01:24:36 PM Dan Carpenter wrote: > Facts: > 1) None of these four error messages will ever be printed. > http://lwn.net/Articles/627419/ > 2) These messages are a waste of RAM. So this is what the changelog should be saying, not that it "fixes checkpatch warnings". checkpatch warnings in *existing* code are meaningless, unless they uncover a *real* problem in it which quite arguably this one is. But in those cases patch changelogs should talk about the *real* problems and they don't even need to mention checkpatch then as far as I'm concerned. Send this one with a better changelog and I'll apply it. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.