From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Date: Mon, 20 Nov 2017 22:20:21 +0000 Subject: Re: [PATCH] afs: remove redundant assignment of dvnode to itself Message-Id: <27271.1511216421@warthog.procyon.org.uk> List-Id: References: <20171120135820.32596-1-colin.king@canonical.com> In-Reply-To: <20171120135820.32596-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: dhowells@redhat.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Colin King wrote: > From: Colin Ian King > > The assignment of dvnode to itself is redundant and can be removed. > Cleans up warning detected by cppcheck: > > fs/afs/dir.c:975: (warning) Redundant assignment of 'dvnode' to itself. > > Fixes: d2ddc776a458 ("afs: Overhaul volume and server record caching and fileserver rotation") > Signed-off-by: Colin Ian King Applied, thanks. David