public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: kernel-janitors@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 5/5] misc/pti: Delete an unnecessary return statement in two functions
Date: Tue, 09 Jan 2018 18:33:27 +0000	[thread overview]
Message-ID: <2741f1bd-ba63-8ff6-e88b-4084ac608b65@users.sourceforge.net> (raw)
In-Reply-To: <bd359852-a809-280d-3d52-89216edc2058@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 9 Jan 2018 18:52:36 +0100

The script "checkpatch.pl" pointed information out like the following.

WARNING: void function return statements are not generally useful

Thus remove such a statement in the affected functions.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/misc/pti.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c
index 11d92c3f43ba..7f9235e56cc0 100644
--- a/drivers/misc/pti.c
+++ b/drivers/misc/pti.c
@@ -142,7 +142,6 @@ static void pti_write_to_aperture(struct pti_masterchannel *mc,
 		ptiword |= *p++ << (24-(8*i));
 
 	iowrite32(ptiword, aperture);
-	return;
 }
 
 /**
@@ -390,5 +389,4 @@ void pti_writedata(struct pti_masterchannel *mc, u8 *buf, int count)
 		pti_write_to_aperture(mc, buf, count);
-	return;
 }
 EXPORT_SYMBOL_GPL(pti_writedata);
 
-- 
2.15.1


      parent reply	other threads:[~2018-01-09 18:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 18:27 [PATCH 0/5] misc-PTI: Adjustments for some function implementations SF Markus Elfring
2018-01-09 18:28 ` [PATCH 1/5] misc/pti: Delete an error message for a failed memory allocation in two functions SF Markus Elfring
2018-01-09 18:29 ` [PATCH 2/5] misc/pti: Fix a typo in five comment lines SF Markus Elfring
2018-01-09 18:31 ` [PATCH 3/5] misc/pti: Improve a size determination in two functions SF Markus Elfring
2018-01-09 18:32 ` [PATCH 4/5] misc/pti: Adjust 11 checks for null pointers SF Markus Elfring
2018-01-09 18:33 ` SF Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2741f1bd-ba63-8ff6-e88b-4084ac608b65@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox