From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Hunter Date: Thu, 18 Aug 2016 07:36:39 +0000 Subject: Re: [PATCH 06/11] mmc: sdhci-of-esdhc: use of_property_read_bool Message-Id: <29aae420-01ef-b355-2fd8-87860a5f34d0@intel.com> List-Id: References: <1470387411-15879-1-git-send-email-Julia.Lawall@lip6.fr> <1470387411-15879-7-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1470387411-15879-7-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ulf Hansson Cc: Julia Lawall , kernel-janitors@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org On 05/08/16 11:56, Julia Lawall wrote: > Use of_property_read_bool to check for the existence of a property. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression e1,e2; > statement S2,S1; > @@ > - if (of_get_property(e1,e2,NULL)) > + if (of_property_read_bool(e1,e2)) > S1 else S2 > // > > Signed-off-by: Julia Lawall Acked-by: Adrian Hunter > > --- > drivers/mmc/host/sdhci-of-esdhc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c > index 239be2f..fb71c86 100644 > --- a/drivers/mmc/host/sdhci-of-esdhc.c > +++ b/drivers/mmc/host/sdhci-of-esdhc.c > @@ -583,7 +583,7 @@ static int sdhci_esdhc_probe(struct platform_device *pdev) > > np = pdev->dev.of_node; > > - if (of_get_property(np, "little-endian", NULL)) > + if (of_property_read_bool(np, "little-endian")) > host = sdhci_pltfm_init(pdev, &sdhci_esdhc_le_pdata, > sizeof(struct sdhci_esdhc)); > else > >