* Re: [PATCH v3] hung_task: Panic after fixed number of hung tasks
[not found] <20251012115035.2169-1-lirongqing@baidu.com>
@ 2025-10-12 13:26 ` Markus Elfring
2025-10-13 2:14 ` [外部邮件] " Li,Rongqing
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2025-10-12 13:26 UTC (permalink / raw)
To: Li RongQing, linux-doc, linux-kselftest, netdev, linux-arm-kernel,
linux-aspeed, wireguard, Andrew Jeffery, Andrew Morton,
Anshuman Khandual, Arnd Bergmann, David Hildenbrand, Feng Tang,
Florian Westphal, Jakub Kicinski, Jason A . Donenfeld,
Joel Granados, Joel Stanley, Jonathan Corbet, Kees Cook,
Lance Yang, Liam R . Howlett, Lorenzo Stoakes, Masami Hiramatsu,
Paul E . McKenney, Pawan Gupta, Petr Mladek, Phil Auld,
Randy Dunlap, Russell King, Shuah Khan, Simon Horman,
Stanislav Fomichev, Steven Rostedt
Cc: LKML, kernel-janitors
…
> This patch extends the …
Will another imperative wording approach become more helpful for an improved
change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17#n94
…
> +++ b/kernel/hung_task.c
…
@@ -229,9 +232,11 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
…
> trace_sched_process_hang(t);
>
> - if (sysctl_hung_task_panic) {
> + if (sysctl_hung_task_panic &&
> + (total_hung_task >= sysctl_hung_task_panic)) {
…
I suggest to use the following source code variant instead.
if (sysctl_hung_task_panic && total_hung_task >= sysctl_hung_task_panic) {
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [外部邮件] Re: [PATCH v3] hung_task: Panic after fixed number of hung tasks
2025-10-12 13:26 ` [PATCH v3] hung_task: Panic after fixed number of hung tasks Markus Elfring
@ 2025-10-13 2:14 ` Li,Rongqing
0 siblings, 0 replies; 2+ messages in thread
From: Li,Rongqing @ 2025-10-13 2:14 UTC (permalink / raw)
To: Markus Elfring, linux-doc@vger.kernel.org,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, wireguard@lists.zx2c4.com,
Andrew Jeffery, Andrew Morton, Anshuman Khandual, Arnd Bergmann,
David Hildenbrand, Feng Tang, Florian Westphal, Jakub Kicinski,
Jason A . Donenfeld, Joel Granados, Joel Stanley, Jonathan Corbet,
Kees Cook, Lance Yang, Liam R . Howlett, Lorenzo Stoakes,
Masami Hiramatsu, Paul E . McKenney, Pawan Gupta, Petr Mladek,
Phil Auld, Randy Dunlap, Russell King, Shuah Khan, Simon Horman,
Stanislav Fomichev, Steven Rostedt
Cc: LKML, kernel-janitors@vger.kernel.org
> …
> > This patch extends the …
>
> Will another imperative wording approach become more helpful for an
> improved change description?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docum
> entation/process/submitting-patches.rst?h=v6.17#n94
>
will fix in next version
>
> …
> > +++ b/kernel/hung_task.c
> …
> @@ -229,9 +232,11 @@ static void check_hung_task(struct task_struct *t,
> unsigned long timeout) …
> > trace_sched_process_hang(t);
> >
> > - if (sysctl_hung_task_panic) {
> > + if (sysctl_hung_task_panic &&
> > + (total_hung_task >= sysctl_hung_task_panic)) {
> …
>
> I suggest to use the following source code variant instead.
>
> if (sysctl_hung_task_panic && total_hung_task >= sysctl_hung_task_panic)
> {
>
will fix in next version
thanks
-Li
>
> Regards,
> Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-13 2:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20251012115035.2169-1-lirongqing@baidu.com>
2025-10-12 13:26 ` [PATCH v3] hung_task: Panic after fixed number of hung tasks Markus Elfring
2025-10-13 2:14 ` [外部邮件] " Li,Rongqing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox